From: Greg KH <greg@kroah.com>
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag
Date: Wed, 3 Feb 2010 11:00:19 -0800 [thread overview]
Message-ID: <20100203190019.GA12637@kroah.com> (raw)
In-Reply-To: <1265221840-25634-2-git-send-email-albert_herranz@yahoo.es>
On Wed, Feb 03, 2010 at 07:30:39PM +0100, Albert Herranz wrote:
> +/**
> + * hcd_memcpy32_to_coherent - copy data to a bounce buffer
> + * @dst: destination dma bounce buffer
> + * @src: source buffer
> + * @len: number of bytes to copy
> + *
> + * This function copies @len bytes from @src to @dst in 32 bit chunks.
> + * The caller must guarantee that @dst length is 4 byte aligned and
> + * that @dst length is greater than or equal to @src length.
> + */
> +static void *hcd_memcpy32_to_coherent(void *dst, const void *src, size_t len)
Why isn't there platform-specific functions for this already? It seems
a bit odd to bury them in the USB hcd core, when I'm sure that other
people need these, if they haven't already created them.
thanks,
greg k-h
next prev parent reply other threads:[~2010-02-03 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 18:30 [RFC PATCH 0/2] wii: add usb 2.0 support Albert Herranz
2010-02-03 18:30 ` [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag Albert Herranz
2010-02-03 19:00 ` Greg KH [this message]
2010-02-03 19:40 ` Alan Stern
2010-02-04 18:23 ` Albert Herranz
2010-02-04 18:58 ` Alan Stern
2010-02-07 18:10 ` Albert Herranz
2010-02-07 20:26 ` Alan Stern
2010-02-07 23:38 ` Albert Herranz
2010-02-03 18:30 ` [RFC PATCH 2/2] wii: hollywood ehci controller support Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203190019.GA12637@kroah.com \
--to=greg@kroah.com \
--cc=albert_herranz@yahoo.es \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).