From: Paul Mackerras <paulus@samba.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] perf_event: e500 support
Date: Thu, 18 Feb 2010 20:27:06 +1100 [thread overview]
Message-ID: <20100218092706.GD24823@brick.ozlabs.ibm.com> (raw)
In-Reply-To: <2035B8E4-B957-4C66-938E-95C0312DABD3@kernel.crashing.org>
On Wed, Feb 17, 2010 at 09:33:06PM -0600, Kumar Gala wrote:
> Other than splitting the patch did you have any other changes you
> wanted to see before we'd get an Ack. I'd like to see this go in
> for .34.
I thought it was a bit ugly having two different definitions of struct
power_pmu in perf_event.h with ifdefs. Either give the two structs
different names or put them in different files. That plus the
splitting out of the perf_callchain patch were my two main concerns.
Paul.
next prev parent reply other threads:[~2010-02-18 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 21:43 [PATCH] perf_event: e500 support Scott Wood
2010-02-10 22:29 ` Paul Mackerras
2010-02-11 0:06 ` Scott Wood
2010-02-11 3:01 ` Paul Mackerras
2010-02-11 16:56 ` Scott Wood
2010-02-18 3:33 ` Kumar Gala
2010-02-18 9:27 ` Paul Mackerras [this message]
2010-02-18 3:29 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218092706.GD24823@brick.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).