From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: "Steven J. Magnani" <steve@digidescorp.com>
Cc: Zhang Wei <zw@zh-kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [async_tx-next PATCH 1/2] fsldma: Fix cookie issues
Date: Thu, 25 Feb 2010 11:21:59 -0800 [thread overview]
Message-ID: <20100225192159.GA32092@ovro.caltech.edu> (raw)
In-Reply-To: <1266860431-17310-1-git-send-email-steve@digidescorp.com>
On Mon, Feb 22, 2010 at 11:40:31AM -0600, Steven J. Magnani wrote:
> fsl_dma_tx_submit() only sets the cookie on the first descriptor of a
> transaction. It should set the cookie on all.
>
> Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
> ---
> diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> --- a/drivers/dma/fsldma.c 2010-02-22 11:16:36.000000000 -0600
> +++ b/drivers/dma/fsldma.c 2010-02-22 11:24:01.000000000 -0600
> @@ -362,7 +362,7 @@ static dma_cookie_t fsl_dma_tx_submit(st
> if (cookie < 0)
> cookie = 1;
>
> - desc->async_tx.cookie = cookie;
> + child->async_tx.cookie = cookie;
> }
>
> chan->common.cookie = cookie;
>
This looks correct to me. I'm not sure I ever tested the driver with a
chained struct dma_async_tx_descriptor.
Ira
prev parent reply other threads:[~2010-02-25 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 17:40 [async_tx-next PATCH 1/2] fsldma: Fix cookie issues Steven J. Magnani
2010-02-25 19:21 ` Ira W. Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225192159.GA32092@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=steve@digidescorp.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).