From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 25 Mar 2010 17:22:34 -0400 From: David Gibson To: Grant Likely Subject: Re: [PATCH] powerpc/fsl: add device tree binding for QE firmware Message-ID: <20100325212234.GA26649@yookeroo> References: <90D93687-940F-47FB-8CEA-F3C065EA611D@kernel.crashing.org> <4BAA4C8A.70104@freescale.com> <65327.84.105.60.153.1269481760.squirrel@gate.crashing.org> <4BAB7E67.6040707@freescale.com> <4BAB816F.5060405@firmworks.com> <4BAB9120.1060600@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Cc: Scott Wood , linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org, Timur Tabi List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Mar 25, 2010 at 10:59:01AM -0600, Grant Likely wrote: > On Thu, Mar 25, 2010 at 10:36 AM, Timur Tabi wrote: > > Grant Likely wrote: > >> On Thu, Mar 25, 2010 at 9:29 AM, Mitch Bradley wrote: > >>> It seems to me that there are plausible use cases for both direct-inclusion > >>> and indirection.  I don't see any real problems with either, so I would vote > >>> for specifying both alternatives. > >> > >> Ugh.  Then this one driver would need to implement both binding for > >> little, if any, actual benefit. > > > > Although I agree that I don't like supporting both bindings, we could encapsulate the locating of the firmware node in a function.  The function will first look for a child firmware node, and if it doesn't find it, look for a fsl,firmware property.  It will return a pointer to the firmware node regardless. > > > >> I'm sure we can come to an agreement > >> on one method if the firmware absolutely has to be in the tree. > > > > If we have to pick one, then I think the only viable choice is have a separate firmware node and a phandle pointer to it.  Otherwise, I just don't see how we can handle multiple devices needing the same firmware. > > Wait for David to weigh in on this one before making a decision. He > knows the dtb format best. I'll do that when I can. Right now I'm in the middle of intense bringup work so I won't have time for this for a while. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson