linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: alsa-devel@alsa-project.org, kumar.gala@freescale.com,
	linuxppc-dev@ozlabs.org, Timur Tabi <timur@freescale.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers
Date: Wed, 28 Apr 2010 14:00:37 +0100	[thread overview]
Message-ID: <20100428130037.GF31400@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1272428729.24542.70.camel@pasglop>

On Wed, Apr 28, 2010 at 02:25:29PM +1000, Benjamin Herrenschmidt wrote:

> I'd stay stick to the basics and move incrementally up until it stops
> making sense:

>  - First, the basics: nodes for actual physical devices. i2c codecs on
> their i2c busses, DMA controllers, etc...

This is already supported by the ASoC core and has been for about a year
or so, it just needs the device drivers to make use of it.  IIRC the
drivers relevant to PowerPC are pretty much doing so already, but I
didn't actually check.

>  - From there, see what simple properties are better off being put in
> those respective nodes because they represent common enough variants of
> functionality or simply because they are specific attributes of a given
> device that aren't too concerned by the way things are interconnected.

This one is just a case of writing boiler plate for the existing
platform data devices have to convert that from device tree into the
existing formats.  It's not a monumentally edifying task, but I don't
think we really need to worry about it here.

>  - Provide at least one identifier (either in a "sound" virtual device,
> or just use the board's own "compatible" property) to have a .c file to
> put everything together.

This has been the big sticking point so far.  It has been difficult to
get people to accept this idea at all, the idea that there may be more
to the machine specific setup than can be readily expressed in static
data and might even vary dynamically at runtime is what seems to upset
people.  I've been told on a number of occasions that instantiating 
machine specific code that's not part of a specific chip is very
difficult and would cause the device tree to be horribly buggy.

What you're suggesting here is exactly what is supposed to happen from
an ASoC point of view.

> The whole thing is a matter of common sense and a bit of taste :-)

The impression that has been created in the past is that there are
inflexible device tree rules which can't be varied.

  reply	other threads:[~2010-04-28 13:00 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 20:49 [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers Timur Tabi
2010-04-27  6:36 ` Benjamin Herrenschmidt
2010-04-27  8:07   ` [alsa-devel] " Liam Girdwood
2010-04-27 14:52     ` Timur Tabi
2010-04-27 15:20       ` Liam Girdwood
2010-04-27 15:28         ` Timur Tabi
2010-04-27 15:56           ` Timur Tabi
2010-04-27 16:41           ` Liam Girdwood
2010-04-27 18:32             ` Timur Tabi
2010-04-27 19:15               ` Grant Likely
2010-04-27 20:04                 ` Timur Tabi
2010-04-27 20:38                   ` Mark Brown
2010-04-28  4:19                   ` Benjamin Herrenschmidt
2010-04-28  4:18                 ` Benjamin Herrenschmidt
2010-04-30 21:46         ` Timur Tabi
2010-04-30 22:04           ` Timur Tabi
2010-04-27 20:24     ` Grant Likely
2010-04-27 20:46       ` Timur Tabi
2010-04-27 20:59         ` Mark Brown
2010-04-27 21:03           ` Timur Tabi
2010-04-27 21:11             ` Mark Brown
2010-04-28  4:25           ` Benjamin Herrenschmidt
2010-04-28 13:00             ` Mark Brown [this message]
2010-04-29  0:42               ` Benjamin Herrenschmidt
2010-04-28  5:37         ` Grant Likely
2010-04-28 13:35           ` Timur Tabi
2010-04-28 13:57             ` Grant Likely
2010-04-28 16:20               ` Timur Tabi
2010-04-28 16:47                 ` Grant Likely
2010-04-28 17:27                   ` Timur Tabi
2010-04-27 22:29       ` Mark Brown
2010-04-28  2:31         ` Grant Likely
2010-04-28  9:16           ` Mark Brown
2010-04-28  4:10         ` Benjamin Herrenschmidt
2010-04-28 12:07           ` Mark Brown
2010-04-29  0:36             ` Benjamin Herrenschmidt
2010-04-29  3:43               ` Grant Likely
2010-04-28 13:19         ` Timur Tabi
2010-04-28 13:39           ` Mark Brown
2010-04-27  9:54   ` Mark Brown
2010-04-27 10:09     ` Benjamin Herrenschmidt
2010-04-27 10:41       ` Mark Brown
2010-04-27 20:27       ` Grant Likely
2010-04-27 20:50         ` Mark Brown
2010-04-27 20:53           ` Timur Tabi
2010-04-28 12:49         ` [alsa-devel] " Liam Girdwood
2010-04-28 20:35       ` Timur Tabi
2010-04-28 21:58         ` Grant Likely
2010-04-28 22:13           ` Timur Tabi
2010-04-28 22:23             ` Grant Likely
2010-04-29  0:52             ` Benjamin Herrenschmidt
2010-04-29  3:44               ` Grant Likely
2010-04-29  0:50         ` Benjamin Herrenschmidt
2010-04-27 19:21 ` Grant Likely
2010-04-27 20:05   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428130037.GF31400@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=benh@kernel.crashing.org \
    --cc=kumar.gala@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).