From: Simon Horman <horms@verge.net.au>
To: Michael Neuling <mikey@neuling.org>
Cc: Maxim Uvarov <muvarov@gmail.com>,
linuxppc-dev@ozlabs.org, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec-tools, ppc64: fix build error on ppc64
Date: Wed, 5 May 2010 12:33:16 +1000 [thread overview]
Message-ID: <20100505023316.GF13035@verge.net.au> (raw)
In-Reply-To: <15110.1273024133@neuling.org>
On Wed, May 05, 2010 at 11:48:53AM +1000, Michael Neuling wrote:
> 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
> improvements" broke pp64 as it turned on -Werror for all archs.
>
> This fixes the warning and hence ppc64 building.
Thanks.
While I'm very much in favour of using -Werror for testing
and these kind of patches are great, I think that -Werror
by default is rather silly. We can't control what will be
a warning in the future and sometimes fixing warnings isn't
appropriate - for instance there are warnings in fs2dt.c at
the moment, that is currently considered an upstream problem.
In short, this patch is great. But I plan to also remove -Werror
as the default now that its been brought to my attention.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> ---
> I've posted a second patch to fix the issue of changing one archs
> Makefile, effecting all other archs.
>
> kexec/arch/ppc64/fs2dt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: kexec-tools/kexec/arch/ppc64/fs2dt.c
> ===================================================================
> --- kexec-tools.orig/kexec/arch/ppc64/fs2dt.c
> +++ kexec-tools/kexec/arch/ppc64/fs2dt.c
> @@ -357,7 +357,8 @@ static void putprops(char *fn, struct di
> * Compare function used to sort the device-tree directories
> * This function will be passed to scandir.
> */
> -static int comparefunc(const void *dentry1, const void *dentry2)
> +static int comparefunc(const struct dirent **dentry1,
> + const struct dirent **dentry2)
> {
> char *str1 = (*(struct dirent **)dentry1)->d_name;
> char *str2 = (*(struct dirent **)dentry2)->d_name;
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-05-05 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 1:48 [PATCH] kexec-tools, ppc64: fix build error on ppc64 Michael Neuling
2010-05-05 1:56 ` Dale Farnsworth
2010-05-05 2:33 ` Simon Horman [this message]
2010-05-05 3:35 ` Michael Neuling
2010-05-05 3:39 ` Simon Horman
2010-05-05 7:46 ` Maxim Uvarov
2010-05-05 8:29 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505023316.GF13035@verge.net.au \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=muvarov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).