From: Simon Horman <horms@verge.net.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, kexec@lists.infradead.org,
Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH] kexec-tools, ppc64: Fix segfault on parsing of large device trees.
Date: Mon, 10 May 2010 18:19:40 +0900 [thread overview]
Message-ID: <20100510091940.GA16856@verge.net.au> (raw)
In-Reply-To: <31392.1273467303@neuling.org>
On Mon, May 10, 2010 at 02:55:03PM +1000, Michael Neuling wrote:
>
>
> In message <4BE78E06.6080601@ozlabs.org> you wrote:
> >
> > ppc64's fs2dt used to use a fixed-size array into which the device tree
> > was parsed. There was no bounds checking, so with a large device tree other
> > heap data ended up getting stomped -- SIGSEGV time.
> >
> > This patch adds a function, 'dt_reserve', to check whether there's enough spa
> ce
> > left prior to writing data to the array. If not, the array is realloced.
> >
> > Signed-off-by: Matt Evans <matt@ozlabs.org>
>
> FWIW...
>
> Ack-by: Michael Neuling <mikey@neuling.org>
>
> (also added linuxppc-dev@ozlabs.org to CC list)
Thanks, applied.
prev parent reply other threads:[~2010-05-10 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BE78E06.6080601@ozlabs.org>
2010-05-10 4:55 ` [PATCH] kexec-tools, ppc64: Fix segfault on parsing of large device trees Michael Neuling
2010-05-10 9:19 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510091940.GA16856@verge.net.au \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).