From: Sonny Rao <sonnyrao@us.ibm.com>
To: benh@kernel.crashing.org
Cc: sonnyrao@us.ibm.com, linuxppc-dev@lists.ozlabs.org, anton@samba.org
Subject: [PATCH] need check for devices with bad status status property in __of_scan_bus()
Date: Mon, 10 May 2010 20:13:41 -0500 [thread overview]
Message-ID: <20100511011341.GO4036@us.ibm.com> (raw)
Hi Ben, we ran into an issue where it looks like we're not
properly ignoring a pci device with a non-good status property
when we walk the device tree and create our device nodes.
However, the EEH init code does look for the property and
disables EEH on these devices. This leaves us in an
inconsistent where we are poking at a supposedly bad
piece of hardware and RTAS will block our config cycles
because EEH isn't enabled anyway.
This has only been compile tested.
Signed-of-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
Index: common/arch/powerpc/kernel/pci_of_scan.c
===================================================================
--- common/arch/powerpc/kernel.orig/pci_of_scan.c 2010-05-10 20:00:40.000000000 -0500
+++ common/arch/powerpc/kernel/pci_of_scan.c 2010-05-10 20:03:04.000000000 -0500
@@ -310,6 +310,8 @@ static void __devinit __of_scan_bus(stru
/* Scan direct children */
for_each_child_of_node(node, child) {
pr_debug(" * %s\n", child->full_name);
+ if (!of_device_is_available(child))
+ continue;
reg = of_get_property(child, "reg", ®len);
if (reg == NULL || reglen < 20)
continue;
--
Sonny Rao, LTC OzLabs, BML team
next reply other threads:[~2010-05-11 1:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 1:13 Sonny Rao [this message]
2010-05-19 8:47 ` [PATCH] need check for devices with bad status status property in __of_scan_bus() Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511011341.GO4036@us.ibm.com \
--to=sonnyrao@us.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).