From: Stefan Roese <sr@denx.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org, Rupjyoti Sarmah <rsarmah@amcc.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission >
Date: Mon, 17 May 2010 12:06:47 +0200 [thread overview]
Message-ID: <201005171206.47566.sr@denx.de> (raw)
In-Reply-To: <1273966828.21352.670.camel@pasglop>
Hi Ben,
On Sunday 16 May 2010 01:40:28 Benjamin Herrenschmidt wrote:
> > > + SATA0: sata@bffd1000 {
> > > + compatible = "amcc,sata-460ex";
> > > + reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>;
> > > + interrupt-parent = <&UIC3>;
> > > + interrupts = <0x0 0x4 /* SATA */
> > > + 0x5 0x4>; /* AHBDMA */
> > > + };
> > > +
> > >
> > > POB0: opb {
> > >
> > > compatible = "ibm,opb-460ex", "ibm,opb";
> > > #address-cells = <1>;
> >
> > Please put the device tree update in a separate patch to go thru the
> >
> > PowerPC tree.
>
> Additionally, the boot wrapper should probably either remove the node or
> at least use a status property "ok" / "disabled" to represent whether
> the board is configured for SATA or PCIe x1...
U-Boot already sets the "status" property of the PCIe or SATA node
accordingly. Just let me know if this doesn't work for you.
Cheers,
Stefan
next prev parent reply other threads:[~2010-05-17 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 17:57 [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission > Rupjyoti Sarmah
2010-05-14 17:44 ` Sergei Shtylyov
2010-05-15 23:40 ` Benjamin Herrenschmidt
2010-05-17 10:06 ` Stefan Roese [this message]
2010-05-17 10:36 ` Benjamin Herrenschmidt
2010-05-14 21:56 ` Jeff Garzik
2010-05-19 1:49 ` Jassi Brar
2010-05-19 9:53 ` Alan Cox
2010-05-19 11:19 ` Jassi Brar
-- strict thread matches above, loose matches on Subject: below --
2010-06-04 12:26 [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission> Rupjyoti Sarmah
2010-06-06 18:52 ` Josh Boyer
2010-06-06 21:09 ` Wolfgang Denk
2010-06-18 4:34 ` Jassi Brar
2010-06-29 1:33 ` Marek Vasut
2010-06-29 12:20 ` Rupjyoti Sarmah
2010-06-29 12:44 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005171206.47566.sr@denx.de \
--to=sr@denx.de \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@amcc.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).