From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev@ozlabs.org, Milton Miller <miltonm@bga.com>
Subject: Re: [PATCH v5] powerpc: Add hibernation support for FSL BookE processors
Date: Tue, 18 May 2010 09:59:13 +0400 [thread overview]
Message-ID: <20100518055913.GA15998@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <ECFF23B7-26B3-42D1-8609-FB53054BEF06@kernel.crashing.org>
On Mon, May 17, 2010 at 04:22:37PM -0500, Kumar Gala wrote:
[...]
> > arch/powerpc/kernel/Makefile | 8 +-
> > arch/powerpc/kernel/swsusp_booke.S | 193 ++++++++++++++++++++++++++++++++++++
> > 2 files changed, 199 insertions(+), 2 deletions(-)
> > create mode 100644 arch/powerpc/kernel/swsusp_booke.S
>
> Is there board specific code to go along with this?
Nope.
> When I enable I get:
>
> arch/powerpc/kernel/built-in.o: In function `cpu_idle':
> /home/galak/git/master/powerpc/arch/powerpc/kernel/idle.c:98: undefined reference to `cpu_die'
> make: *** [.tmp_vmlinux1] Error 1
This isn't caused by hibernation or my patch specifically.
Instead, it's a long standing issue, enabling CONFIG_SMP and
CONFIG_SUSPEND is enough to trigger this. Patch exists:
http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg27982.html
No idea why it didn't make Linus' tree.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-05-18 5:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 21:38 [PATCH v2] powerpc: Add hibernation support for FSL BookE processors Anton Vorontsov
2010-04-15 18:45 ` Anton Vorontsov
2010-04-15 19:20 ` Kumar Gala
2010-04-15 19:36 ` Anton Vorontsov
2010-04-15 20:05 ` Scott Wood
2010-04-15 20:18 ` Scott Wood
2010-04-16 11:56 ` [PATCH v3] " Anton Vorontsov
2010-04-16 15:54 ` Scott Wood
2010-04-16 19:03 ` [PATCH v4] " Anton Vorontsov
2010-05-17 18:03 ` Kumar Gala
2010-05-17 18:12 ` Scott Wood
2010-05-17 18:56 ` [PATCH v5] " Anton Vorontsov
2010-05-17 21:17 ` Kumar Gala
2010-05-17 21:22 ` Kumar Gala
2010-05-18 5:59 ` Anton Vorontsov [this message]
2010-04-16 5:40 ` [PATCH v2] " Anton Vorontsov
2010-04-16 15:48 ` Scott Wood
2010-04-16 19:03 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518055913.GA15998@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).