From: Scott Wood <scottwood@freescale.com>
To: hellohello <hellohello008@163.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: Problem of PowerPc 82xx when using smc
Date: Thu, 20 May 2010 12:06:08 -0500 [thread overview]
Message-ID: <20100520170608.GA10712@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <042201caf7fa$9d038a20$a51cbcc0@sfdomain.com>
On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote:
>
> I find a problem in
> drivers/serial/cpm_uart/cpm_uart_cpm2.c:
> int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)
> {
> ... ...
> pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos;
> /*The above line should be ：*/
> pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->rx_nrfifos;
No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
already happens as part of pointer arithmetic.
> return 0;
> }
>
> Where to get the newest code for kernel?
git.kernel.org
> How to know whether it is already patched by anyone else? Just search in this mail list?
As well as the current git tree.
-Scott
next prev parent reply other threads:[~2010-05-20 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 8:58 Problem of PowerPc 82xx when using smc hellohello
2010-05-20 17:06 ` Scott Wood [this message]
2010-05-21 3:33 ` hellohello
2010-05-21 11:20 ` Gary Thomas
2010-05-22 3:37 ` hellohello
2010-05-21 17:28 ` Scott Wood
2010-05-22 2:51 ` hellohello
-- strict thread matches above, loose matches on Subject: below --
2010-05-22 6:23 hellohello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520170608.GA10712@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=hellohello008@163.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).