* Problem of PowerPc 82xx when using smc
@ 2010-05-20 8:58 hellohello
2010-05-20 17:06 ` Scott Wood
0 siblings, 1 reply; 8+ messages in thread
From: hellohello @ 2010-05-20 8:58 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
I find a problem in
drivers/serial/cpm_uart/cpm_uart_cpm2.c:
int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)
{
... ...
pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos;
/*The above line should be ：*/
pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->rx_nrfifos;
return 0;
}
Where to get the newest code for kernel?
How to know whether it is already patched by anyone else? Just search in this mail list?
My Linux Kernel is 2.6.25, platform is mpc82XX.
Thanks for any help.
[-- Attachment #2: Type: text/html, Size: 1275 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Problem of PowerPc 82xx when using smc
2010-05-20 8:58 Problem of PowerPc 82xx when using smc hellohello
@ 2010-05-20 17:06 ` Scott Wood
2010-05-21 3:33 ` hellohello
0 siblings, 1 reply; 8+ messages in thread
From: Scott Wood @ 2010-05-20 17:06 UTC (permalink / raw)
To: hellohello; +Cc: linuxppc-dev
On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote:
>
> I find a problem in
> drivers/serial/cpm_uart/cpm_uart_cpm2.c:
> int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)
> {
> ... ...
> pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos;
> /*The above line should be ：*/
> pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->rx_nrfifos;
No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
already happens as part of pointer arithmetic.
> return 0;
> }
>
> Where to get the newest code for kernel?
git.kernel.org
> How to know whether it is already patched by anyone else? Just search in this mail list?
As well as the current git tree.
-Scott
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Problem of PowerPc 82xx when using smc
2010-05-20 17:06 ` Scott Wood
@ 2010-05-21 3:33 ` hellohello
2010-05-21 11:20 ` Gary Thomas
2010-05-21 17:28 ` Scott Wood
0 siblings, 2 replies; 8+ messages in thread
From: hellohello @ 2010-05-21 3:33 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
PiBObywgaXQgc2hvdWxkbid0IC0tIHJ4X2JkX2Jhc2UgaXMgb2YgdHlwZSAiY2JkX3QgKiIsIHNv
IHRoZSBtdWx0aXBsaWNhdGlvbg0KPiBhbHJlYWR5IGhhcHBlbnMgYXMgcGFydCBvZiBwb2ludGVy
IGFyaXRobWV0aWMuDQotLS1ZZXMsIHlvdSBhcmUgcmlnaHQuIEkgbWFkZSBhIGJhc2ljIG1pc3Rh
a2UuIA0KDQpCdXQgbm93IEkgaGF2ZSBhbm90aGVyIHF1ZXN0aW9uLg0KVGhlIFNNQzEgcGFyYW1z
IGNhbiBiZSByZWxvY2F0ZWQgdG8gYW55IG9mZnNldCBvZiB0aGUgRFBSQU0gb24gYSA2NCBieXRl
IGJvdW5kYXJ5LCBub3QgYXMgdGhlIFNDQzEsIHdoaWNoIG11c3QgYmUgIGF0IDB4ODAwMCBvZmZz
ZXQgb2YgdGhlIERQUkFNLg0KVGhlIFNNQzEgcGFyYW1zIGJhc2UgaXMgc2V0IGF0IDB4ODdGQyBv
ZmZzZXQgb2YgdGhlIERQUkFNLg0KDQpTbyBpZiAgSSB3YW50IFNNQzEgcGFyYW1zIHN0YXJ0IGF0
ICAweDIwMCBpbiBEUFJBTSAgLCBJIHNob3VsZCBzZXQgMHgyMDAgdG8gdGhlIDB4ODdGQyBvZmZz
ZXQgb2YgdGhlIERQUkFNLg0KSSBoYXZlIHNlZSB0aGlzIGNvZGUgaW4gdS1ib290LCBidXQgSSBj
YW4gbm90IGZpbmQgdGhpcyBjb2RlIGluIG5laXRoZXIgY3BtX3VhcnRfY3BtMi5jIG5vciBjcG1f
dWFydF9jb3JlLmMuDQoNClNob3VsZCBJIGFkZCB0aGVzZSBjb2RlIHRvICBjcG1fdWFydF9jb3Jl
LmM/DQoNCi0tZHBfbWVtID0gY3BtX2RwcmFtX2FkZHIoMHg4N2ZjKTsNCi0tb3V0X2JlMTYoZHBf
bWVtLCBTTUMxX0JBU0UpOw0KDQoNCg0KDQoNCg0KDQotLS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0t
LS0tIA0KRnJvbTogIlNjb3R0IFdvb2QiIDxzY290dHdvb2RAZnJlZXNjYWxlLmNvbT4NClRvOiAi
aGVsbG9oZWxsbyIgPGhlbGxvaGVsbG8wMDhAMTYzLmNvbT4NCkNjOiA8bGludXhwcGMtZGV2QGxp
c3RzLm96bGFicy5vcmc+DQpTZW50OiBGcmlkYXksIE1heSAyMSwgMjAxMCAxOjA2IEFNDQpTdWJq
ZWN0OiBSZTogUHJvYmxlbSBvZiBQb3dlclBjIDgyeHggd2hlbiB1c2luZyBzbWMNCg0KDQo+IE9u
IFRodSwgTWF5IDIwLCAyMDEwIGF0IDA0OjU4OjI3UE0gKzA4MDAsIGhlbGxvaGVsbG8gd3JvdGU6
DQo+PiANCj4+IEkgZmluZCBhIHByb2JsZW0gaW4gDQo+PiBkcml2ZXJzL3NlcmlhbC9jcG1fdWFy
dC9jcG1fdWFydF9jcG0yLmM6DQo+PiBpbnQgY3BtX3VhcnRfYWxsb2NidWYoc3RydWN0IHVhcnRf
Y3BtX3BvcnQgKnBpbmZvLCB1bnNpZ25lZCBpbnQgaXNfY29uKQ0KPj4gew0KPj4gLi4uIC4uLg0K
Pj4gcGluZm8tPnR4X2JkX2Jhc2UgPSBwaW5mby0+cnhfYmRfYmFzZSArIHBpbmZvLT5yeF9ucmZp
Zm9zOw0KPj4gLypUaGUgYWJvdmUgbGluZSBzaG91bGQgYmUg77yaKi8NCj4+ICBwaW5mby0+dHhf
YmRfYmFzZSA9IHBpbmZvLT5yeF9iZF9iYXNlICsgc2l6ZW9mKGNiZF90KSAqIHBpbmZvLT5yeF9u
cmZpZm9zOw0KPiANCj4gTm8sIGl0IHNob3VsZG4ndCAtLSByeF9iZF9iYXNlIGlzIG9mIHR5cGUg
ImNiZF90ICoiLCBzbyB0aGUgbXVsdGlwbGljYXRpb24NCj4gYWxyZWFkeSBoYXBwZW5zIGFzIHBh
cnQgb2YgcG9pbnRlciBhcml0aG1ldGljLg0KPiANCj4+IHJldHVybiAwOw0KPj4gfQ0KPj4gDQo+
PiBXaGVyZSB0byBnZXQgdGhlIG5ld2VzdCBjb2RlIGZvciBrZXJuZWw/DQo+IA0KPiBnaXQua2Vy
bmVsLm9yZw0KPiANCj4+IEhvdyB0byBrbm93IHdoZXRoZXIgaXQgaXMgYWxyZWFkeSBwYXRjaGVk
IGJ5IGFueW9uZSBlbHNlPyAgSnVzdCBzZWFyY2ggaW4gIHRoaXMgbWFpbCBsaXN0Pw0KPiANCj4g
QXMgd2VsbCBhcyB0aGUgY3VycmVudCBnaXQgdHJlZS4NCj4gDQo+IC1TY290dA0KPiBfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPiBMaW51eHBwYy1kZXYg
bWFpbGluZyBsaXN0DQo+IExpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IGh0dHBzOi8v
bGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Problem of PowerPc 82xx when using smc
2010-05-21 3:33 ` hellohello
@ 2010-05-21 11:20 ` Gary Thomas
2010-05-22 3:37 ` hellohello
2010-05-21 17:28 ` Scott Wood
1 sibling, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2010-05-21 11:20 UTC (permalink / raw)
To: hellohello; +Cc: Scott Wood, linuxppc-dev
On 05/20/2010 09:33 PM, hellohello wrote:
>> No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
>> already happens as part of pointer arithmetic.
> ---Yes, you are right. I made a basic mistake.
>
> But now I have another question.
> The SMC1 params can be relocated to any offset of the DPRAM on a 64 byte boundary, not as the SCC1, which must be at 0x8000 offset of the DPRAM.
> The SMC1 params base is set at 0x87FC offset of the DPRAM.
>
> So if I want SMC1 params start at 0x200 in DPRAM , I should set 0x200 to the 0x87FC offset of the DPRAM.
> I have see this code in u-boot, but I can not find this code in neither cpm_uart_cpm2.c nor cpm_uart_core.c.
>
> Should I add these code to cpm_uart_core.c?
>
> --dp_mem = cpm_dpram_addr(0x87fc);
> --out_be16(dp_mem, SMC1_BASE);
Why are you mucking about with this code at all? SMCx serial certainly
works on every platform I've ever used, 8xx and 8xxx as well.
> ----- Original Message -----
> From: "Scott Wood"<scottwood@freescale.com>
> To: "hellohello"<hellohello008@163.com>
> Cc:<linuxppc-dev@lists.ozlabs.org>
> Sent: Friday, May 21, 2010 1:06 AM
> Subject: Re: Problem of PowerPc 82xx when using smc
>
>
>> On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote:
>>>
>>> I find a problem in
>>> drivers/serial/cpm_uart/cpm_uart_cpm2.c:
>>> int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)
>>> {
>>> ... ...
>>> pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos;
>>> /*The above line should be ：*/
>>> pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->rx_nrfifos;
>>
>> No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
>> already happens as part of pointer arithmetic.
>>
>>> return 0;
>>> }
>>>
>>> Where to get the newest code for kernel?
>>
>> git.kernel.org
>>
>>> How to know whether it is already patched by anyone else? Just search in this mail list?
>>
>> As well as the current git tree.
>>
>> -Scott
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Problem of PowerPc 82xx when using smc
2010-05-21 11:20 ` Gary Thomas
@ 2010-05-22 3:37 ` hellohello
0 siblings, 0 replies; 8+ messages in thread
From: hellohello @ 2010-05-22 3:37 UTC (permalink / raw)
To: Gary Thomas; +Cc: linuxppc-dev
Pj4gU2hvdWxkIEkgYWRkIHRoZXNlIGNvZGUgdG8gIGNwbV91YXJ0X2NvcmUuYz8NCj4+DQo+PiAt
LWRwX21lbSA9IGNwbV9kcHJhbV9hZGRyKDB4ODdmYyk7DQo+PiAtLW91dF9iZTE2KGRwX21lbSwg
U01DMV9CQVNFKTsNCj4gDQo+IFdoeSBhcmUgeW91IG11Y2tpbmcgYWJvdXQgd2l0aCB0aGlzIGNv
ZGUgYXQgYWxsPyAgU01DeCBzZXJpYWwgY2VydGFpbmx5DQo+IHdvcmtzIG9uIGV2ZXJ5IHBsYXRm
b3JtIEkndmUgZXZlciB1c2VkLCA4eHggYW5kIDh4eHggYXMgd2VsbC4NCj4gDQoNCkkgaGF2ZSBu
byBpbnRlcmVzdCBvbiBtdWNraW5nIGFib3V0IGFueSBjb2RlIGF0IGFsbC4gDQpNeSBpbnRlcmVz
dCBpcyAgbXkgc21jMSdzIHByb2JsZW0uDQpTb21lIGRvY3RvciBzYXkgInRvb3RoIG9rLCB5b3Ug
anVzdCBlYXQgdG9vIG11Y2ggY29sZCBmb29kICAuLi4uIg0KU29tZSBkb2N0b3Igc2F5ICJNYXli
ZSB0b290aCBoYXMgYSBsaXR0bGUgaG9sZSwgICB0YWtlIGEgbG9vayAuLi4uIg0KT25lIGRvY3Rv
ciBqdXN0IHNheSwgInRvb3RoYWNoZT8gV2h5IGFyZSB5b3UgbXVja2luZyBhYm91dCB3aXRoIHRo
aXMgdG9vdGggYXQgYWxsPyAsICB0b290aCB3b3JrcyB3ZWxsIG9uIGV2ZXJ5b25lJ3MgbW91dGgs
IGJveXMgYW5kIGdpcmxzIGFzIHdlbGwiDQoNCg0KDQoNCg0KDQoNCg0KDQotLS0tLSBPcmlnaW5h
bCBNZXNzYWdlIC0tLS0tIA0KRnJvbTogIkdhcnkgVGhvbWFzIiA8Z2FyeUBtbGJhc3NvYy5jb20+
DQpUbzogImhlbGxvaGVsbG8iIDxoZWxsb2hlbGxvMDA4QDE2My5jb20+DQpDYzogIlNjb3R0IFdv
b2QiIDxzY290dHdvb2RAZnJlZXNjYWxlLmNvbT47IDxsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz
Lm9yZz4NClNlbnQ6IEZyaWRheSwgTWF5IDIxLCAyMDEwIDc6MjAgUE0NClN1YmplY3Q6IFJlOiBQ
cm9ibGVtIG9mIFBvd2VyUGMgODJ4eCB3aGVuIHVzaW5nIHNtYw0KDQoNCj4gT24gMDUvMjAvMjAx
MCAwOTozMyBQTSwgaGVsbG9oZWxsbyB3cm90ZToNCj4+PiBObywgaXQgc2hvdWxkbid0IC0tIHJ4
X2JkX2Jhc2UgaXMgb2YgdHlwZSAiY2JkX3QgKiIsIHNvIHRoZSBtdWx0aXBsaWNhdGlvbg0KPj4+
IGFscmVhZHkgaGFwcGVucyBhcyBwYXJ0IG9mIHBvaW50ZXIgYXJpdGhtZXRpYy4NCj4+IC0tLVll
cywgeW91IGFyZSByaWdodC4gSSBtYWRlIGEgYmFzaWMgbWlzdGFrZS4NCj4+DQo+PiBCdXQgbm93
IEkgaGF2ZSBhbm90aGVyIHF1ZXN0aW9uLg0KPj4gVGhlIFNNQzEgcGFyYW1zIGNhbiBiZSByZWxv
Y2F0ZWQgdG8gYW55IG9mZnNldCBvZiB0aGUgRFBSQU0gb24gYSA2NCBieXRlIGJvdW5kYXJ5LCBu
b3QgYXMgdGhlIFNDQzEsIHdoaWNoIG11c3QgYmUgIGF0IDB4ODAwMCBvZmZzZXQgb2YgdGhlIERQ
UkFNLg0KPj4gVGhlIFNNQzEgcGFyYW1zIGJhc2UgaXMgc2V0IGF0IDB4ODdGQyBvZmZzZXQgb2Yg
dGhlIERQUkFNLg0KPj4NCj4+IFNvIGlmICBJIHdhbnQgU01DMSBwYXJhbXMgc3RhcnQgYXQgIDB4
MjAwIGluIERQUkFNICAsIEkgc2hvdWxkIHNldCAweDIwMCB0byB0aGUgMHg4N0ZDIG9mZnNldCBv
ZiB0aGUgRFBSQU0uDQo+PiBJIGhhdmUgc2VlIHRoaXMgY29kZSBpbiB1LWJvb3QsIGJ1dCBJIGNh
biBub3QgZmluZCB0aGlzIGNvZGUgaW4gbmVpdGhlciBjcG1fdWFydF9jcG0yLmMgbm9yIGNwbV91
YXJ0X2NvcmUuYy4NCj4+DQo+PiBTaG91bGQgSSBhZGQgdGhlc2UgY29kZSB0byAgY3BtX3VhcnRf
Y29yZS5jPw0KPj4NCj4+IC0tZHBfbWVtID0gY3BtX2RwcmFtX2FkZHIoMHg4N2ZjKTsNCj4+IC0t
b3V0X2JlMTYoZHBfbWVtLCBTTUMxX0JBU0UpOw0KPiANCj4gV2h5IGFyZSB5b3UgbXVja2luZyBh
Ym91dCB3aXRoIHRoaXMgY29kZSBhdCBhbGw/ICBTTUN4IHNlcmlhbCBjZXJ0YWlubHkNCj4gd29y
a3Mgb24gZXZlcnkgcGxhdGZvcm0gSSd2ZSBldmVyIHVzZWQsIDh4eCBhbmQgOHh4eCBhcyB3ZWxs
Lg0KPiANCj4+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0NCj4+IEZyb206ICJTY290dCBX
b29kIjxzY290dHdvb2RAZnJlZXNjYWxlLmNvbT4NCj4+IFRvOiAiaGVsbG9oZWxsbyI8aGVsbG9o
ZWxsbzAwOEAxNjMuY29tPg0KPj4gQ2M6PGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnPg0K
Pj4gU2VudDogRnJpZGF5LCBNYXkgMjEsIDIwMTAgMTowNiBBTQ0KPj4gU3ViamVjdDogUmU6IFBy
b2JsZW0gb2YgUG93ZXJQYyA4Mnh4IHdoZW4gdXNpbmcgc21jDQo+Pg0KPj4NCj4+PiBPbiBUaHUs
IE1heSAyMCwgMjAxMCBhdCAwNDo1ODoyN1BNICswODAwLCBoZWxsb2hlbGxvIHdyb3RlOg0KPj4+
Pg0KPj4+PiBJIGZpbmQgYSBwcm9ibGVtIGluDQo+Pj4+IGRyaXZlcnMvc2VyaWFsL2NwbV91YXJ0
L2NwbV91YXJ0X2NwbTIuYzoNCj4+Pj4gaW50IGNwbV91YXJ0X2FsbG9jYnVmKHN0cnVjdCB1YXJ0
X2NwbV9wb3J0ICpwaW5mbywgdW5zaWduZWQgaW50IGlzX2NvbikNCj4+Pj4gew0KPj4+PiAuLi4g
Li4uDQo+Pj4+IHBpbmZvLT50eF9iZF9iYXNlID0gcGluZm8tPnJ4X2JkX2Jhc2UgKyBwaW5mby0+
cnhfbnJmaWZvczsNCj4+Pj4gLypUaGUgYWJvdmUgbGluZSBzaG91bGQgYmUg77yaKi8NCj4+Pj4g
ICBwaW5mby0+dHhfYmRfYmFzZSA9IHBpbmZvLT5yeF9iZF9iYXNlICsgc2l6ZW9mKGNiZF90KSAq
IHBpbmZvLT5yeF9ucmZpZm9zOw0KPj4+DQo+Pj4gTm8sIGl0IHNob3VsZG4ndCAtLSByeF9iZF9i
YXNlIGlzIG9mIHR5cGUgImNiZF90ICoiLCBzbyB0aGUgbXVsdGlwbGljYXRpb24NCj4+PiBhbHJl
YWR5IGhhcHBlbnMgYXMgcGFydCBvZiBwb2ludGVyIGFyaXRobWV0aWMuDQo+Pj4NCj4+Pj4gcmV0
dXJuIDA7DQo+Pj4+IH0NCj4+Pj4NCj4+Pj4gV2hlcmUgdG8gZ2V0IHRoZSBuZXdlc3QgY29kZSBm
b3Iga2VybmVsPw0KPj4+DQo+Pj4gZ2l0Lmtlcm5lbC5vcmcNCj4+Pg0KPj4+PiBIb3cgdG8ga25v
dyB3aGV0aGVyIGl0IGlzIGFscmVhZHkgcGF0Y2hlZCBieSBhbnlvbmUgZWxzZT8gIEp1c3Qgc2Vh
cmNoIGluICB0aGlzIG1haWwgbGlzdD8NCj4+Pg0KPj4+IEFzIHdlbGwgYXMgdGhlIGN1cnJlbnQg
Z2l0IHRyZWUuDQo+Pj4NCj4+PiAtU2NvdHQNCj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXw0KPj4+IExpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QNCj4+
PiBMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPj4+IGh0dHBzOi8vbGlzdHMub3psYWJz
Lm9yZy9saXN0aW5mby9saW51eHBwYy1kZXYNCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fDQo+PiBMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0DQo+PiBM
aW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPj4gaHR0cHM6Ly9saXN0cy5vemxhYnMub3Jn
L2xpc3RpbmZvL2xpbnV4cHBjLWRldg0KPiANCj4gLS0gDQo+IC0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiBHYXJ5IFRob21hcyAg
ICAgICAgICAgICAgICAgfCAgQ29uc3VsdGluZyBmb3IgdGhlDQo+IE1MQiBBc3NvY2lhdGVzICAg
ICAgICAgICAgICB8ICAgIEVtYmVkZGVkIHdvcmxkDQo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiBfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPiBMaW51eHBwYy1kZXYgbWFpbGluZyBs
aXN0DQo+IExpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IGh0dHBzOi8vbGlzdHMub3ps
YWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Problem of PowerPc 82xx when using smc
2010-05-21 3:33 ` hellohello
2010-05-21 11:20 ` Gary Thomas
@ 2010-05-21 17:28 ` Scott Wood
2010-05-22 2:51 ` hellohello
1 sibling, 1 reply; 8+ messages in thread
From: Scott Wood @ 2010-05-21 17:28 UTC (permalink / raw)
To: hellohello; +Cc: linuxppc-dev
On 05/20/2010 10:33 PM, hellohello wrote:
>> No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
>> already happens as part of pointer arithmetic.
> ---Yes, you are right. I made a basic mistake.
>
> But now I have another question.
> The SMC1 params can be relocated to any offset of the DPRAM on a 64 byte boundary, not as the SCC1, which must be at 0x8000 offset of the DPRAM.
> The SMC1 params base is set at 0x87FC offset of the DPRAM.
>
> So if I want SMC1 params start at 0x200 in DPRAM , I should set 0x200 to the 0x87FC offset of the DPRAM.
> I have see this code in u-boot, but I can not find this code in neither cpm_uart_cpm2.c nor cpm_uart_core.c.
>
> Should I add these code to cpm_uart_core.c?
Newer kernels support dynamically allocating this parameter RAM. Older
kernels use whatever u-boot chose.
Why do you want to set it to a particular address?
-Scott
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Problem of PowerPc 82xx when using smc
2010-05-21 17:28 ` Scott Wood
@ 2010-05-22 2:51 ` hellohello
0 siblings, 0 replies; 8+ messages in thread
From: hellohello @ 2010-05-22 2:51 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
DQo+IE5ld2VyIGtlcm5lbHMgc3VwcG9ydCBkeW5hbWljYWxseSBhbGxvY2F0aW5nIHRoaXMgcGFy
YW1ldGVyIFJBTS4gIE9sZGVyIA0KPiBrZXJuZWxzIHVzZSB3aGF0ZXZlciB1LWJvb3QgY2hvc2Uu
DQo+IA0KPiBXaHkgZG8geW91IHdhbnQgdG8gc2V0IGl0IHRvIGEgcGFydGljdWxhciBhZGRyZXNz
Pw0KDQpUaGVyZSBzaG91bGQgYmUgc29tZSBjb2RlIHRvIHNldCBTTUMxX0JBU0UgdG8gdGhlIDB4
ODdGQyBvZmZzZXQgb2YgdGhlIERQUkFNLCB3aGF0ZXZlciBTTUMxX0JBU0UgaXMgZml4ZWQgb3Ig
ZHluYW1pY2FsbHkgYWxsb2NhdGVkIC4NCg0KTXkga2VybmVsIGlzIDIuNi4yNSwgdGhpcyBTTUMx
X0JBU0UgdmFsdWUgY2FuIGJlIHRyYW5zZmVycmVkIHRvICBrZXJuZWwgYnkgZHRzIHRyZWUsIGJ1
dCBJIGhhdmUgbm90IGZpbmQgdGhlIGNvZGUgdG8gc2V0IGl0IHRvICAweDg3RkMgb2Zmc2V0IG9m
IHRoZSBEUFJBTS4gT3IgdGhlcmUgaXMgYW5vdGhlciB3YXkgdG8gc29sdmUgaXQgPw0KDQoNCg0K
LS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLSANCkZyb206ICJTY290dCBXb29kIiA8c2NvdHR3
b29kQGZyZWVzY2FsZS5jb20+DQpUbzogImhlbGxvaGVsbG8iIDxoZWxsb2hlbGxvMDA4QDE2My5j
b20+DQpDYzogPGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnPg0KU2VudDogU2F0dXJkYXks
IE1heSAyMiwgMjAxMCAxOjI4IEFNDQpTdWJqZWN0OiBSZTogUHJvYmxlbSBvZiBQb3dlclBjIDgy
eHggd2hlbiB1c2luZyBzbWMNCg0KDQo+IE9uIDA1LzIwLzIwMTAgMTA6MzMgUE0sIGhlbGxvaGVs
bG8gd3JvdGU6DQo+Pj4gTm8sIGl0IHNob3VsZG4ndCAtLSByeF9iZF9iYXNlIGlzIG9mIHR5cGUg
ImNiZF90ICoiLCBzbyB0aGUgbXVsdGlwbGljYXRpb24NCj4+PiBhbHJlYWR5IGhhcHBlbnMgYXMg
cGFydCBvZiBwb2ludGVyIGFyaXRobWV0aWMuDQo+PiAtLS1ZZXMsIHlvdSBhcmUgcmlnaHQuIEkg
bWFkZSBhIGJhc2ljIG1pc3Rha2UuDQo+Pg0KPj4gQnV0IG5vdyBJIGhhdmUgYW5vdGhlciBxdWVz
dGlvbi4NCj4+IFRoZSBTTUMxIHBhcmFtcyBjYW4gYmUgcmVsb2NhdGVkIHRvIGFueSBvZmZzZXQg
b2YgdGhlIERQUkFNIG9uIGEgNjQgYnl0ZSBib3VuZGFyeSwgbm90IGFzIHRoZSBTQ0MxLCB3aGlj
aCBtdXN0IGJlICBhdCAweDgwMDAgb2Zmc2V0IG9mIHRoZSBEUFJBTS4NCj4+IFRoZSBTTUMxIHBh
cmFtcyBiYXNlIGlzIHNldCBhdCAweDg3RkMgb2Zmc2V0IG9mIHRoZSBEUFJBTS4NCj4+DQo+PiBT
byBpZiAgSSB3YW50IFNNQzEgcGFyYW1zIHN0YXJ0IGF0ICAweDIwMCBpbiBEUFJBTSAgLCBJIHNo
b3VsZCBzZXQgMHgyMDAgdG8gdGhlIDB4ODdGQyBvZmZzZXQgb2YgdGhlIERQUkFNLg0KPj4gSSBo
YXZlIHNlZSB0aGlzIGNvZGUgaW4gdS1ib290LCBidXQgSSBjYW4gbm90IGZpbmQgdGhpcyBjb2Rl
IGluIG5laXRoZXIgY3BtX3VhcnRfY3BtMi5jIG5vciBjcG1fdWFydF9jb3JlLmMuDQo+Pg0KPj4g
U2hvdWxkIEkgYWRkIHRoZXNlIGNvZGUgdG8gIGNwbV91YXJ0X2NvcmUuYz8NCj4gDQo+IE5ld2Vy
IGtlcm5lbHMgc3VwcG9ydCBkeW5hbWljYWxseSBhbGxvY2F0aW5nIHRoaXMgcGFyYW1ldGVyIFJB
TS4gIE9sZGVyIA0KPiBrZXJuZWxzIHVzZSB3aGF0ZXZlciB1LWJvb3QgY2hvc2UuDQo+IA0KPiBX
aHkgZG8geW91IHdhbnQgdG8gc2V0IGl0IHRvIGEgcGFydGljdWxhciBhZGRyZXNzPw0KPiANCj4g
LVNjb3R0DQo+
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Problem of PowerPc 82xx when using smc
@ 2010-05-22 6:23 hellohello
0 siblings, 0 replies; 8+ messages in thread
From: hellohello @ 2010-05-22 6:23 UTC (permalink / raw)
To: hellohello, Scott Wood; +Cc: linuxppc-dev
Pj4gTmV3ZXIga2VybmVscyBzdXBwb3J0IGR5bmFtaWNhbGx5IGFsbG9jYXRpbmcgdGhpcyBwYXJh
bWV0ZXIgUkFNLiAgT2xkZXIgDQo+PiBrZXJuZWxzIHVzZSB3aGF0ZXZlciB1LWJvb3QgY2hvc2Uu
DQoNCkkgc2VlLiAgICBUaGFua3MgLg0KVS1ib290IGluaXRpYWxpemUgU01DMSBmb3IgdGhlIGZp
cnN0IHRpbWUsIGFuZCBoYXMgc2V0IFNNQzFfQkFTRSB0byB0aGUgMHg4N0ZDIG9mZnNldCBvZiB0
aGUgRFBSQU0uDQprZXJuZWwgIDIuNi4yNSBpbml0aWFsaXplIFNNQzEgZm9yIHRoZSBzZWNvbmQg
dGltZSBhcyB3ZWxsIGFzICB3aGljaCBhcmUgZG9uZSBpbiB1LWJvb3QsICBleGNlcHQgdG8gIHNl
dCBTTUMxX0JBU0UgYWdhaW4uDQpTbyBpZiBTTUMxX0JBU0UgaXMgdHJhbnNmZXJyZWQgdG8ga2Vy
bmVsIGJ5IGR0cyBjb3JyZWN0bHksIFNNQzEgc2hvdWxkIHdvcmsgd2VsbC4NClRoZSBwcm9ibGVt
IG11c3QgYmUgbXkgZHRzIGZpbGUgLG5vdCB0aGUgY29kZS4NCg0KDQoNCg0KLS0tLS0gT3JpZ2lu
YWwgTWVzc2FnZSAtLS0tLSANCkZyb206ICJoZWxsb2hlbGxvIiA8aGVsbG9oZWxsbzAwOEAxNjMu
Y29tPg0KVG86ICJTY290dCBXb29kIiA8c2NvdHR3b29kQGZyZWVzY2FsZS5jb20+DQpDYzogPGxp
bnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnPg0KU2VudDogU2F0dXJkYXksIE1heSAyMiwgMjAx
MCAxMDo1MSBBTQ0KU3ViamVjdDogUmU6IFByb2JsZW0gb2YgUG93ZXJQYyA4Mnh4IHdoZW4gdXNp
bmcgc21jDQoNCg0KPiANCj4+IE5ld2VyIGtlcm5lbHMgc3VwcG9ydCBkeW5hbWljYWxseSBhbGxv
Y2F0aW5nIHRoaXMgcGFyYW1ldGVyIFJBTS4gIE9sZGVyIA0KPj4ga2VybmVscyB1c2Ugd2hhdGV2
ZXIgdS1ib290IGNob3NlLg0KPj4gDQo+PiBXaHkgZG8geW91IHdhbnQgdG8gc2V0IGl0IHRvIGEg
cGFydGljdWxhciBhZGRyZXNzPw0KPiANCj4gVGhlcmUgc2hvdWxkIGJlIHNvbWUgY29kZSB0byBz
ZXQgU01DMV9CQVNFIHRvIHRoZSAweDg3RkMgb2Zmc2V0IG9mIHRoZSBEUFJBTSwgd2hhdGV2ZXIg
U01DMV9CQVNFIGlzIGZpeGVkIG9yIGR5bmFtaWNhbGx5IGFsbG9jYXRlZCAuDQo+IA0KPiBNeSBr
ZXJuZWwgaXMgMi42LjI1LCB0aGlzIFNNQzFfQkFTRSB2YWx1ZSBjYW4gYmUgdHJhbnNmZXJyZWQg
dG8gIGtlcm5lbCBieSBkdHMgdHJlZSwgYnV0IEkgaGF2ZSBub3QgZmluZCB0aGUgY29kZSB0byBz
ZXQgaXQgdG8gIDB4ODdGQyBvZmZzZXQgb2YgdGhlIERQUkFNLiBPciB0aGVyZSBpcyBhbm90aGVy
IHdheSB0byBzb2x2ZSBpdCA/DQo+IA0KPiANCj4gDQo+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2Ug
LS0tLS0gDQo+IEZyb206ICJTY290dCBXb29kIiA8c2NvdHR3b29kQGZyZWVzY2FsZS5jb20+DQo+
IFRvOiAiaGVsbG9oZWxsbyIgPGhlbGxvaGVsbG8wMDhAMTYzLmNvbT4NCj4gQ2M6IDxsaW51eHBw
Yy1kZXZAbGlzdHMub3psYWJzLm9yZz4NCj4gU2VudDogU2F0dXJkYXksIE1heSAyMiwgMjAxMCAx
OjI4IEFNDQo+IFN1YmplY3Q6IFJlOiBQcm9ibGVtIG9mIFBvd2VyUGMgODJ4eCB3aGVuIHVzaW5n
IHNtYw0KPiANCj4gDQo+PiBPbiAwNS8yMC8yMDEwIDEwOjMzIFBNLCBoZWxsb2hlbGxvIHdyb3Rl
Og0KPj4+PiBObywgaXQgc2hvdWxkbid0IC0tIHJ4X2JkX2Jhc2UgaXMgb2YgdHlwZSAiY2JkX3Qg
KiIsIHNvIHRoZSBtdWx0aXBsaWNhdGlvbg0KPj4+PiBhbHJlYWR5IGhhcHBlbnMgYXMgcGFydCBv
ZiBwb2ludGVyIGFyaXRobWV0aWMuDQo+Pj4gLS0tWWVzLCB5b3UgYXJlIHJpZ2h0LiBJIG1hZGUg
YSBiYXNpYyBtaXN0YWtlLg0KPj4+DQo+Pj4gQnV0IG5vdyBJIGhhdmUgYW5vdGhlciBxdWVzdGlv
bi4NCj4+PiBUaGUgU01DMSBwYXJhbXMgY2FuIGJlIHJlbG9jYXRlZCB0byBhbnkgb2Zmc2V0IG9m
IHRoZSBEUFJBTSBvbiBhIDY0IGJ5dGUgYm91bmRhcnksIG5vdCBhcyB0aGUgU0NDMSwgd2hpY2gg
bXVzdCBiZSAgYXQgMHg4MDAwIG9mZnNldCBvZiB0aGUgRFBSQU0uDQo+Pj4gVGhlIFNNQzEgcGFy
YW1zIGJhc2UgaXMgc2V0IGF0IDB4ODdGQyBvZmZzZXQgb2YgdGhlIERQUkFNLg0KPj4+DQo+Pj4g
U28gaWYgIEkgd2FudCBTTUMxIHBhcmFtcyBzdGFydCBhdCAgMHgyMDAgaW4gRFBSQU0gICwgSSBz
aG91bGQgc2V0IDB4MjAwIHRvIHRoZSAweDg3RkMgb2Zmc2V0IG9mIHRoZSBEUFJBTS4NCj4+PiBJ
IGhhdmUgc2VlIHRoaXMgY29kZSBpbiB1LWJvb3QsIGJ1dCBJIGNhbiBub3QgZmluZCB0aGlzIGNv
ZGUgaW4gbmVpdGhlciBjcG1fdWFydF9jcG0yLmMgbm9yIGNwbV91YXJ0X2NvcmUuYy4NCj4+Pg0K
Pj4+IFNob3VsZCBJIGFkZCB0aGVzZSBjb2RlIHRvICBjcG1fdWFydF9jb3JlLmM/DQo+PiANCj4+
IE5ld2VyIGtlcm5lbHMgc3VwcG9ydCBkeW5hbWljYWxseSBhbGxvY2F0aW5nIHRoaXMgcGFyYW1l
dGVyIFJBTS4gIE9sZGVyIA0KPj4ga2VybmVscyB1c2Ugd2hhdGV2ZXIgdS1ib290IGNob3NlLg0K
Pj4gDQo+PiBXaHkgZG8geW91IHdhbnQgdG8gc2V0IGl0IHRvIGEgcGFydGljdWxhciBhZGRyZXNz
Pw0KPj4gDQo+PiAtU2NvdHQNCj4+
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-05-22 6:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20 8:58 Problem of PowerPc 82xx when using smc hellohello
2010-05-20 17:06 ` Scott Wood
2010-05-21 3:33 ` hellohello
2010-05-21 11:20 ` Gary Thomas
2010-05-22 3:37 ` hellohello
2010-05-21 17:28 ` Scott Wood
2010-05-22 2:51 ` hellohello
-- strict thread matches above, loose matches on Subject: below --
2010-05-22 6:23 hellohello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).