From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, "K.Prasad" <prasad@linux.vnet.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: [RFC PATCH] powerpc: Emulate nop too
Date: Thu, 27 May 2010 19:42:03 +0530 [thread overview]
Message-ID: <20100527141203.GA20770@in.ibm.com> (raw)
In-Reply-To: <20100520124955.GA29903@brick.ozlabs.ibm.com>
Hi Paul,
While we are at it, can we also add nop to the list of emulated
instructions?
Ananth
---
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Emulate ori 0,0,0 (nop).
The long winded way is to do:
case 24:
rd = (instr >> 21) & 0x1f;
if (rd != 0)
break;
rb = (instr >> 11) & 0x1f;
if (rb != 0)
break;
imm = (instr & 0xffff);
if (imm == 0) {
regs->nip += 4;
return 1;
}
break;
But, the following is more straightforward for this case at least.
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
arch/powerpc/lib/sstep.c | 6 ++++++
1 file changed, 6 insertions(+)
Index: linux-27may/arch/powerpc/lib/sstep.c
===================================================================
--- linux-27may.orig/arch/powerpc/lib/sstep.c
+++ linux-27may/arch/powerpc/lib/sstep.c
@@ -412,6 +412,12 @@ int __kprobes emulate_step(struct pt_reg
int err;
mm_segment_t oldfs;
+ /* ori 0,0,0 is a nop. Emulate that too */
+ if (instr == 0x60000000) {
+ regs->nip += 4;
+ return 1;
+ }
+
opcode = instr >> 26;
switch (opcode) {
case 16: /* bc */
next prev parent reply other threads:[~2010-05-27 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 12:49 [RFC PATCH] powerpc: Emulate most load and store instructions in emulate_step() Paul Mackerras
2010-05-21 16:35 ` Milton Miller
2010-05-27 14:12 ` Ananth N Mavinakayanahalli [this message]
2010-05-27 20:22 ` [RFC PATCH] powerpc: Emulate nop too Kumar Gala
2010-05-28 3:52 ` Ananth N Mavinakayanahalli
2010-05-28 2:05 ` Paul Mackerras
2010-05-28 5:19 ` powerpc: remove resume_execution() in kprobes Ananth N Mavinakayanahalli
2010-05-28 2:28 ` [RFC PATCH] powerpc: Emulate nop too Michael Neuling
2010-05-28 4:16 ` Ananth N Mavinakayanahalli
2010-05-28 4:23 ` Michael Neuling
2010-05-28 5:54 ` Ananth N Mavinakayanahalli
2010-06-02 5:25 ` [RFC PATCH] powerpc: Emulate most load and store instructions in emulate_step() K.Prasad
2010-06-02 6:00 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527141203.GA20770@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).