From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pw0-f42.google.com (mail-pw0-f42.google.com [209.85.160.42]) by ozlabs.org (Postfix) with ESMTP id D1450B7D16 for ; Tue, 1 Jun 2010 15:05:48 +1000 (EST) Received: by pwi1 with SMTP id 1so19074pwi.15 for ; Mon, 31 May 2010 22:05:47 -0700 (PDT) Date: Mon, 31 May 2010 22:05:39 -0700 From: Dmitry Torokhov To: Richard Purdie Subject: Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL) Message-ID: <20100601050538.GA7391@core.coreip.homeip.net> References: <1275310552-14685-1-git-send-email-w.sang@pengutronix.de> <20100531190911.GC30712@core.coreip.homeip.net> <1275342512.24079.1559.camel@rex> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1275342512.24079.1559.camel@rex> Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Alessandro Rubini , Samuel Ortiz , lm-sensors@lm-sensors.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, Paul Gortmaker , devel@driverdev.osuosl.org, rtc-linux@googlegroups.com, Riku Voipio , Mauro Carvalho Chehab , Jean Delvare , "Ben Dooks \(embedded platforms\)" , Liam Girdwood , Alessandro Zummo , Guillaume Ligneul , George Joseph , Mark Brown , Colin Leroy , David Woodhouse List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 31, 2010 at 10:48:32PM +0100, Richard Purdie wrote: > On Mon, 2010-05-31 at 12:09 -0700, Dmitry Torokhov wrote: > > On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > > > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > > > devices are not really unregistered, but merely detached from their driver, it > > > used to be the drivers obligation to clear this pointer during remove() or a > > > failed probe(). As a couple of drivers forgot to do this, it was agreed that it > > > was cleaner if the i2c-core does this clearance when appropriate, as there is > > > no guarantee for the lifetime of the clientdata-pointer after remove() anyhow. > > > This feature was added to the core with commit > > > e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers. > > > > > > As there is no need anymore to clear the clientdata-pointer, remove all current > > > occurrences in the drivers to simplify the code and prevent confusion. > > > > > > Signed-off-by: Wolfram Sang > > > Cc: Jean Delvare > > > --- > > > > > > Some more notes: > > > > > > I waited for rc1 as I knew there were some drivers/patches coming along which > > > needed to be processed, too. > > > > > > I'd suggest that this goes via the i2c-tree, so we get rid of all occurences at > > > once. > > > > > > > Frankly I'd prefer taking input stuff through my tree with the goal of > > .36 merge window just to minimize potential merge issues. This is a > > simple cleanup patch that has no dependencies, so there is little gain > > from doing it all in one go. > > How about asking Linus to take this one now, then its done and we can > all move on rather than queuing up problems for the next merge window? > That should work. Acked-by: Dmitry Torokhov > Acked-by: Richard Purdie > -- Dmitry