From: Jean Delvare <khali@linux-fr.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
linux-i2c@vger.kernel.org, devel@driverdev.osuosl.org,
Samuel Ortiz <sameo@linux.intel.com>,
lm-sensors@lm-sensors.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org,
Paul Gortmaker <p_gortmaker@yahoo.com>,
Riku Voipio <riku.voipio@iki.fi>,
rtc-linux@googlegroups.com,
Alessandro Rubini <rubini@ipvvis.unipv.it>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
"Ben Dooks \(embedded platforms\)" <ben-linux@fluff.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Alessandro Zummo <a.zummo@towertech.it>,
Guillaume Ligneul <guillaume.ligneul@gmail.com>,
George Joseph <george.joseph@fairview5.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Colin Leroy <colin@colino.net>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)
Date: Tue, 1 Jun 2010 15:53:10 +0200 [thread overview]
Message-ID: <20100601155310.3781fce6@hyperion.delvare> (raw)
In-Reply-To: <1275310552-14685-1-git-send-email-w.sang@pengutronix.de>
On Mon, 31 May 2010 14:55:48 +0200, Wolfram Sang wrote:
> I2C-drivers can use the clientdata-pointer to point to private data. As I2C
> devices are not really unregistered, but merely detached from their driver, it
> used to be the drivers obligation to clear this pointer during remove() or a
> failed probe(). As a couple of drivers forgot to do this, it was agreed that it
> was cleaner if the i2c-core does this clearance when appropriate, as there is
> no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
> This feature was added to the core with commit
> e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.
>
> As there is no need anymore to clear the clientdata-pointer, remove all current
> occurrences in the drivers to simplify the code and prevent confusion.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Jean Delvare <khali@linux-fr.org>
> (...)
Applied, thanks. Will go to Linus in the next few days.
--
Jean Delvare
prev parent reply other threads:[~2010-06-01 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 12:55 [PATCH] drivers: remove all i2c_set_clientdata(client, NULL) Wolfram Sang
2010-05-31 13:01 ` Mark Brown
2010-05-31 16:54 ` Greg KH
2010-05-31 19:09 ` Dmitry Torokhov
2010-05-31 20:57 ` Jean Delvare
2010-05-31 21:48 ` Richard Purdie
2010-06-01 5:05 ` Dmitry Torokhov
2010-06-01 13:53 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601155310.3781fce6@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=a.zummo@towertech.it \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=colin@colino.net \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=george.joseph@fairview5.com \
--cc=gregkh@suse.de \
--cc=guillaume.ligneul@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
--cc=lrg@slimlogic.co.uk \
--cc=mchehab@infradead.org \
--cc=p_gortmaker@yahoo.com \
--cc=riku.voipio@iki.fi \
--cc=rpurdie@rpsys.net \
--cc=rtc-linux@googlegroups.com \
--cc=rubini@ipvvis.unipv.it \
--cc=sameo@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).