From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset.
Date: Wed, 9 Jun 2010 11:25:44 +0100 [thread overview]
Message-ID: <20100609102543.GB5618@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1276015562-28928-3-git-send-email-emillbrandt@dekaresearch.com>
On Tue, Jun 08, 2010 at 12:46:02PM -0400, Eric Millbrandt wrote:
> + switch (psc_dma->id) {
> + case 0:
> + gpio_mux = MPC52xx_GPIO_PSC1_MASK; break;
> + case 1:
> + gpio_mux = MPC52xx_GPIO_PSC2_MASK; break;
Please don't place the break on the same line as the statement, it's
not good for legibility.
> + dev_err(psc_dma->dev, "cold reset\n");
You shouldn't be logging this as an error, doing a cold reset is
perfectly normal.
next prev parent reply other threads:[~2010-06-09 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 16:46 [PATCH 0/2] mpc5200 ac97 gpio reset Eric Millbrandt
2010-06-08 16:46 ` [PATCH 1/2] powerpc/5200: Export port-config Eric Millbrandt
2010-06-08 16:46 ` [PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset Eric Millbrandt
2010-06-09 10:25 ` Mark Brown [this message]
2010-06-10 22:11 ` [PATCH 1/2] powerpc/5200: Export port-config Grant Likely
2010-06-09 0:24 ` [PATCH 0/2] mpc5200 ac97 gpio reset Jon Smirl
2010-06-09 6:13 ` Wolfgang Denk
2010-06-09 10:30 ` Mark Brown
2010-06-09 14:24 ` Eric Millbrandt
2010-06-10 22:07 ` Grant Likely
2010-06-10 23:14 ` Mark Brown
2010-06-10 23:31 ` Grant Likely
2010-06-09 12:21 ` Jon Smirl
2010-06-09 14:21 ` Eric Millbrandt
2010-06-09 14:32 ` Mark Brown
2010-06-09 14:41 ` Jon Smirl
2010-06-09 15:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609102543.GB5618@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=emillbrandt@dekaresearch.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).