From: Paul Mackerras <paulus@samba.org>
To: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
Benjamin Herrenschmidt <benh@au1.ibm.com>,
shaggy@linux.vnet.ibm.com,
Frederic Weisbecker <fweisbec@gmail.com>,
David Gibson <dwg@au1.ibm.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Alan Stern <stern@rowland.harvard.edu>,
Roland McGrath <roland@redhat.com>
Subject: Re: [Patch 5/5] PPC64-HWBKPT: Discard extraneous interrupt due to accesses outside symbol length
Date: Thu, 10 Jun 2010 22:40:24 +1000 [thread overview]
Message-ID: <20100610124024.GA28613@brick.ozlabs.ibm.com> (raw)
In-Reply-To: <20100609102559.GF20332@in.ibm.com>
On Wed, Jun 09, 2010 at 03:55:59PM +0530, K.Prasad wrote:
> + if (!((bp->attr.bp_addr <= dar) &&
> + (dar <= (bp->attr.bp_addr + bp->attr.bp_len)))) {
> + /*
> + * This exception is triggered not because of a memory access
> + * on the monitored variable but in the double-word address
> + * range in which it is contained. We will consume this
> + * exception, considering it as 'noise'.
> + */
> + info->extraneous_interrupt = true;
> + }
Ummm, don't you need to add "else info->extraneous_interrupt = false;"
here? I don't see anywhere that you ever clear it otherwise.
Also, I think you need to do the "if (!info->extraneous_interrupt)"
check around the call to perf_bp_event() later on in
hw_breakpoint_handler() as well as around the call in
single_step_dabr_instruction().
Paul.
next prev parent reply other threads:[~2010-06-10 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100609101417.644628763@linux.vnet.ibm.com>
2010-06-09 10:25 ` [Patch 1/5] Allow arch-specific cleanup before breakpoint unregistration K.Prasad
2010-06-09 10:25 ` [Patch 2/5] PPC64-HWBKPT: Implement hw-breakpoints for PowerPC BookIII S K.Prasad
2010-06-09 10:25 ` [Patch 3/5] PPC64-HWBKPT: Handle concurrent alignment interrupts K.Prasad
2010-06-09 10:25 ` [Patch 4/5] PPC64-HWBKPT: Enable hw-breakpoints while handling intervening signals K.Prasad
2010-06-09 10:25 ` [Patch 5/5] PPC64-HWBKPT: Discard extraneous interrupt due to accesses outside symbol length K.Prasad
2010-06-10 12:40 ` Paul Mackerras [this message]
2010-06-15 6:07 ` K.Prasad
[not found] <20100615055010.108795721@linux.vnet.ibm.com>
2010-06-15 6:06 ` K.Prasad
[not found] <20100528061928.677651410@linux.vnet.ibm.com>
2010-05-28 6:41 ` K.Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610124024.GA28613@brick.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=benh@au1.ibm.com \
--cc=dwg@au1.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=roland@redhat.com \
--cc=shaggy@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).