From: "K.Prasad" <prasad@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Benjamin Herrenschmidt <benh@au1.ibm.com>
Subject: Re: [Patch 0/5] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver XXII
Date: Tue, 15 Jun 2010 11:39:42 +0530 [thread overview]
Message-ID: <20100615060942.GB2971@in.ibm.com> (raw)
In-Reply-To: <20100615015459.GA30479@drongo>
On Tue, Jun 15, 2010 at 11:54:59AM +1000, Paul Mackerras wrote:
> On Fri, Jun 04, 2010 at 12:21:45PM +0530, K.Prasad wrote:
>
> > Meanwhile I tested the per-cpu breakpoints with the new emulate_step
> > patch (refer linuxppc-dev message-id:
> > 20100602112903.GB30149@brick.ozlabs.ibm.com) and they continue to fail
> > due to emulate_step() failure, in my case, on a "lwz r0,0(r28)"
> > instruction.
>
> You need to pass the instruction word to emulate_step(), not the
> instruction address. Also you need to have the full GPR set
> available. The patch below fixes these problems. I'll fold these
> changes into your patch 2/5.
>
> Paul.
The breakpoints that used to fail before (due to emulate_step() failure)
are now working fine upon applying this patch.
Please include this patch along with my 2/5 as indicated by you.
Thanks,
K.Prasad
prev parent reply other threads:[~2010-06-15 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 6:39 [Patch 0/5] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver XXII K.Prasad
2010-06-02 11:33 ` Paul Mackerras
2010-06-04 6:51 ` K.Prasad
2010-06-04 9:06 ` Paul Mackerras
2010-06-07 7:03 ` K.Prasad
2010-06-07 11:25 ` Paul Mackerras
2010-06-09 10:32 ` K.Prasad
2010-06-10 4:23 ` Paul Mackerras
2010-06-15 1:54 ` Paul Mackerras
2010-06-15 6:09 ` K.Prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615060942.GB2971@in.ibm.com \
--to=prasad@linux.vnet.ibm.com \
--cc=benh@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).