Re: [PATCH] powerpc: introduce basic support for the Freescale P1022DS reference board

[Kim Phillips <kim.phillips@freescale.com>]

On Tue, 29 Jun 2010 17:39:17 -0600
"Tabi Timur-B04825" <B04825@freescale.com> wrote:

> Kim Phillips wrote:
> > On Tue, 29 Jun 2010 16:34:34 -0500
> > Timur Tabi<timur@freescale.com>  wrote:
> >
> >> Introduce basic support for the Freescale P1022DS reference board, based on the
> >> Freescale BSP for this board.
> >>
> >> Details: No DIU video or SSI audio support, no MMC/SD card support, 36-bit and
> >> SWIOTLB support enabled, 36-bit DTS only, and CONFIG_NO_HZ disabled because it
> >> causes performance problems on this kernel.
> >
> > what kind of performance problems?
> 
> See my post on linuxppc-dev about CONFIG_NO_HZ.

looks like it should be easily bisected, esp. since
mpc85xx_smp_defconfig has NO_HZ=y.

> >> +			queue-group@0{
> >> +				#address-cells =<1>;
> >> +				#size-cells =<1>;
> >> +				reg =<0xB1000 0x1000>;
> >> +				fsl,rx-err-int-map =<0xAA>;
> >> +				fsl,tx-int-map =<0xAA>;
> >> +				interrupts =<35 2 36 2 40 2>;
> >> +			};
> >> +			queue-group@1{
> >> +				#address-cells =<1>;
> >> +				#size-cells =<1>;
> >> +				reg =<0xB5000 0x1000>;
> >> +				fsl,rx-err-int-map =<0x55>;
> >> +				fsl,tx-int-map =<0x55>;
> >> +				interrupts =<51 2 52 2 67 2>;
> >> +			};
> >
> > these queue-group nodes, fsl,{r,t}x-* properties...
> 
> I just copied this tree from the BSP.  I have no idea what they should ok 
> like.  Can you be more specific?

eh?  you submitted the patch; I'm just calling out the
foreign/undocumented matter in it.

> >> +		crypto@30000 {
> >
> >> +			fsl,multi-host-mode = "dual";
> >> +			fsl,channel-remap =<0x3>;
> >
> > and the above two properties aren't supported by their respective
> > drivers, nor are they listed in the dts bindings documentation.
> 
> Then please tell me what these nodes should look like.

delete them?

Kim