From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e37.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 0CACCB6EF0 for ; Thu, 1 Jul 2010 06:03:55 +1000 (EST) Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5UK24ig029842 for ; Wed, 30 Jun 2010 14:02:04 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5UK3bFE136032 for ; Wed, 30 Jun 2010 14:03:37 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5UK3RNp004470 for ; Wed, 30 Jun 2010 14:03:28 -0600 Date: Wed, 30 Jun 2010 16:03:25 -0400 From: Josh Boyer To: Jeff Garzik Subject: Re: [PATCH v1]460EX on-chip SATA driver Message-ID: <20100630200325.GD7756@zod.rchland.ibm.com> References: <201006241327.o5ODRY6m032299@amcc.com> <20100630115808.2D9241524EC@gemini.denx.de> <3b928476b2fffdcf0694e5436e8a482f@mail.gmail.com> <20100630184728.C02D014EBF9@gemini.denx.de> <4C2B9831.9020801@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4C2B9831.9020801@pobox.com> Cc: Wolfgang Denk , linux-ide@vger.kernel.org, Rupjyoti Sarmah , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sr@denx.de List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 30, 2010 at 03:17:05PM -0400, Jeff Garzik wrote: > On 06/30/2010 02:47 PM, Wolfgang Denk wrote: >> Dear Rupjyoti Sarmah, >> >> In message<3b928476b2fffdcf0694e5436e8a482f@mail.gmail.com> you wrote: >>> >>> I took the mainline kernel v2.6.35-rc3 and downloaded using the git >>> download link. >>> I created the patch on 6/24/2010 after doing a git pull. >> >> I don;t think that you used v2.6.35-rc3; using this version, I still >> get this: >> >> drivers/ata/sata_dwc_460ex.c:43:1: warning: "DRV_NAME" redefined >> In file included from drivers/ata/sata_dwc_460ex.c:38: >> drivers/ata/libata.h:31:1: warning: this is the location of the previous definition >> drivers/ata/sata_dwc_460ex.c:44:1: warning: "DRV_VERSION" redefined >> drivers/ata/libata.h:32:1: warning: this is the location of the previous definition >> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_scr_read': >> drivers/ata/sata_dwc_460ex.c:777: error: 'struct ata_port' has no member named 'ioaddr' >> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_scr_write': >> drivers/ata/sata_dwc_460ex.c:793: error: 'struct ata_port' has no member named 'ioaddr' >> drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_error_intr': >> drivers/ata/sata_dwc_460ex.c:844: error: 'struct ata_port_operations' has no member named 'sff_check_status' > > It looks like -your- build config is missing CONFIG_ATA_SFF or similar. > > If you actually look at include/linux/libata.h, you see that struct > ata_port_operations most definitely has a member named sff_check_status, > for example. Ditto ata_port and member ioaddr, etc. The driver doesn't depend on CONFIG_ATA_SFF in it's Kconfig file, but seems to require it at build time. Isn't that something that needs fixing in the driver? josh