* [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
@ 2010-07-02 12:41 Anton Vorontsov
2010-07-07 21:45 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Anton Vorontsov @ 2010-07-02 12:41 UTC (permalink / raw)
To: Andrew Morton
Cc: Peter Tyser, linux-kernel, Dave Jiang, linuxppc-dev,
Doug Thompson
Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
driver became non-selectable.
This patch fixes the issue by switching to PPC_85xx symbol.
Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
---
drivers/edac/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index aedef79..0d2f9db 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -209,7 +209,7 @@ config EDAC_I5100
config EDAC_MPC85XX
tristate "Freescale MPC83xx / MPC85xx"
- depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
+ depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
help
Support for error detection and correction on the Freescale
MPC8349, MPC8560, MPC8540, MPC8548
--
1.7.0.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
2010-07-02 12:41 [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency Anton Vorontsov
@ 2010-07-07 21:45 ` Andrew Morton
2010-07-08 4:56 ` Anton Vorontsov
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2010-07-07 21:45 UTC (permalink / raw)
To: Anton Vorontsov
Cc: Peter Tyser, linux-kernel, Dave Jiang, linuxppc-dev,
Doug Thompson
On Fri, 2 Jul 2010 16:41:11 +0400
Anton Vorontsov <avorontsov@mvista.com> wrote:
> Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
> Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
> driver became non-selectable.
hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
six months ago. How come nobody noticed?
> This patch fixes the issue by switching to PPC_85xx symbol.
>
> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
> ---
> drivers/edac/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index aedef79..0d2f9db 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -209,7 +209,7 @@ config EDAC_I5100
>
> config EDAC_MPC85XX
> tristate "Freescale MPC83xx / MPC85xx"
> - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
> + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
> help
> Support for error detection and correction on the Freescale
> MPC8349, MPC8560, MPC8540, MPC8548
I suppose we shold scoot this into 2.6.35 and mark it for -stable
backporting. All very odd.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
2010-07-07 21:45 ` Andrew Morton
@ 2010-07-08 4:56 ` Anton Vorontsov
2010-07-11 16:20 ` Kumar Gala
0 siblings, 1 reply; 4+ messages in thread
From: Anton Vorontsov @ 2010-07-08 4:56 UTC (permalink / raw)
To: Andrew Morton
Cc: Peter Tyser, linux-kernel, Dave Jiang, linuxppc-dev,
Doug Thompson
On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote:
> On Fri, 2 Jul 2010 16:41:11 +0400
> Anton Vorontsov <avorontsov@mvista.com> wrote:
>
> > Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
> > Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
> > driver became non-selectable.
>
> hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
> six months ago. How come nobody noticed?
Dunno. Well, it's hard to notice these sorts of things until
somebody actually needs this driver on MPC85xx platform. :-)
> > This patch fixes the issue by switching to PPC_85xx symbol.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
> > ---
[...]
> > - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
> > + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
> > help
> > Support for error detection and correction on the Freescale
> > MPC8349, MPC8560, MPC8540, MPC8548
>
> I suppose we shold scoot this into 2.6.35 and mark it for -stable
> backporting. All very odd.
Yeah, -stable 2.6.{33,34} sounds good.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
2010-07-08 4:56 ` Anton Vorontsov
@ 2010-07-11 16:20 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2010-07-11 16:20 UTC (permalink / raw)
To: Anton Vorontsov
Cc: Peter Tyser, linux-kernel, Dave Jiang, linuxppc-dev,
Doug Thompson, Andrew Morton
On Jul 7, 2010, at 11:56 PM, Anton Vorontsov wrote:
> On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote:
>> On Fri, 2 Jul 2010 16:41:11 +0400
>> Anton Vorontsov <avorontsov@mvista.com> wrote:
>>
>>> Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
>>> Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
>>> driver became non-selectable.
>>
>> hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
>> six months ago. How come nobody noticed?
>
> Dunno. Well, it's hard to notice these sorts of things until
> somebody actually needs this driver on MPC85xx platform. :-)
>
>>> This patch fixes the issue by switching to PPC_85xx symbol.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
>>> ---
> [...]
>>> - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
>>> + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
>>> help
>>> Support for error detection and correction on the Freescale
>>> MPC8349, MPC8560, MPC8540, MPC8548
>>
>> I suppose we shold scoot this into 2.6.35 and mark it for -stable
>> backporting. All very odd.
>
> Yeah, -stable 2.6.{33,34} sounds good.
>
> Thanks.
we should add this to mpc85xx_defconfig so we build by default.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-11 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-02 12:41 [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency Anton Vorontsov
2010-07-07 21:45 ` Andrew Morton
2010-07-08 4:56 ` Anton Vorontsov
2010-07-11 16:20 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).