From: Scott Wood <scottwood@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: "Albrecht Dreß" <albrecht.dress@arcor.de>,
"Steve Deiters" <SteveDeiters@basler.com>,
linuxppc-dev@lists.ozlabs.org,
"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH] arch/powerpc/lib/copy_32.S: Use alternate memcpy for MPC512x and MPC52xx
Date: Thu, 8 Jul 2010 15:09:04 -0500 [thread overview]
Message-ID: <20100708150904.79feffdd@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <DC489835-1F97-49DA-A00C-7D73D0EC0900@kernel.crashing.org>
On Thu, 8 Jul 2010 21:30:33 +0200
Segher Boessenkool <segher@kernel.crashing.org> wrote:
> > Actually, this is something which might need closer attention -
> > and maybe some support in the device tree indicating which read or
> > write width a device can accept?
>
> There already is "device-width"; the drivers never should use any
> other access width unless they *know* that will work.
Wouldn't you want to use "bank-width" instead? "device-width" might
not even work if, say, you've got two 8-bit chips interleaved, feeding
into a bus controller in 16-bit mode that only accepts 16-bit accesses.
It would be nice to have a device tree property that can specify that
all access widths supported by the CPU will work, though.
-Scott
next prev parent reply other threads:[~2010-07-08 20:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 16:04 [PATCH] arch/powerpc/lib/copy_32.S: Use alternate memcpy for MPC512x and MPC52xx Steve Deiters
2010-06-29 16:58 ` Segher Boessenkool
2010-07-08 5:10 ` Benjamin Herrenschmidt
2010-07-08 5:38 ` Grant Likely
2010-07-08 14:38 ` Steve Deiters
2010-07-08 15:22 ` Grant Likely
2010-07-08 18:40 ` Albrecht Dreß
2010-07-08 19:30 ` Segher Boessenkool
2010-07-08 20:09 ` Scott Wood [this message]
2010-07-09 12:59 ` Segher Boessenkool
2010-07-09 16:18 ` Scott Wood
2010-07-08 20:09 ` Albrecht Dreß
2010-07-09 13:03 ` Segher Boessenkool
2010-07-11 7:40 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708150904.79feffdd@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=SteveDeiters@basler.com \
--cc=albrecht.dress@arcor.de \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).