From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pfepb.post.tele.dk (pfepb.post.tele.dk [195.41.46.236]) by ozlabs.org (Postfix) with ESMTP id 8641BB6F1B for ; Tue, 13 Jul 2010 19:50:26 +1000 (EST) Date: Tue, 13 Jul 2010 11:50:24 +0200 From: Sam Ravnborg To: Sean MacLennan , Benjamin Herrenschmidt Subject: [ Message-ID: <20100713095024.GA10494@merkur.ravnborg.org> References: <20100628005900.28d4a8e0@lappy.seanm.ca> <20100712203435.08a3e90f@lappy.seanm.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100712203435.08a3e90f@lappy.seanm.ca> Cc: Denys Vlasenko , linuxppc-dev , Michal Marek , Tim Abbott List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg Date: Tue, 13 Jul 2010 11:39:42 +0200 Subject: [PATCH] vmlinux.lds: fix .data..init_task output section (fix popwerpc boot) The .data..init_task output section was missing a load offset causing a popwerpc target to fail to boot. Sean MacLennan tracked it down to the definition of INIT_TASK_DATA_SECTION(). There are only two users of INIT_TASK_DATA_SECTION() in the kernel today: cris and popwerpc. cris do not support relocatable kernels and is thus not impacted by this change. Fix INIT_TASK_DATA_SECTION() to specify load offset like all other output sections. Reported-by: Sean MacLennan Signed-off-by: Sam Ravnborg --- On the assumption that Sean reports that it fixes the warnings/boot issue here is a real patch. Ben - will you take it via the popwerpc tree or shall I ask Michal to take it via kbuild? Sam include/asm-generic/vmlinux.lds.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 48c5299..cdfff74 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -435,7 +435,7 @@ */ #define INIT_TASK_DATA_SECTION(align) \ . = ALIGN(align); \ - .data..init_task : { \ + .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) { \ INIT_TASK_DATA(align) \ } -- 1.6.0.6