* [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers @ 2010-07-15 18:25 Anton Vorontsov 2010-07-16 20:12 ` Scott Wood 0 siblings, 1 reply; 11+ messages in thread From: Anton Vorontsov @ 2010-07-15 18:25 UTC (permalink / raw) To: Andrew Morton Cc: Peter Tyser, linux-kernel, Dave Jiang, linuxppc-dev, Doug Thompson Simply add proper IDs into the device table. Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> --- It appears that the driver has two device ID tables. :-) So, my previous attempt enabled only half of the functionality. Andrew, Can you please replace edac-mpc85xx-add-support-for-mpc8569-edac-controllers.patch with this patch? It also adds some more IDs for the newer chips. Thanks! drivers/edac/mpc85xx_edac.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index 52ca09b..3820879 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -646,8 +646,12 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { { .compatible = "fsl,mpc8555-l2-cache-controller", }, { .compatible = "fsl,mpc8560-l2-cache-controller", }, { .compatible = "fsl,mpc8568-l2-cache-controller", }, + { .compatible = "fsl,mpc8569-l2-cache-controller", }, { .compatible = "fsl,mpc8572-l2-cache-controller", }, + { .compatible = "fsl,p1020-l2-cache-controller", }, + { .compatible = "fsl,p1021-l2-cache-controller", }, { .compatible = "fsl,p2020-l2-cache-controller", }, + { .compatible = "fsl,p4080-l2-cache-controller", }, {}, }; @@ -1120,9 +1124,13 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = { { .compatible = "fsl,mpc8555-memory-controller", }, { .compatible = "fsl,mpc8560-memory-controller", }, { .compatible = "fsl,mpc8568-memory-controller", }, + { .compatible = "fsl,mpc8569-memory-controller", }, { .compatible = "fsl,mpc8572-memory-controller", }, { .compatible = "fsl,mpc8349-memory-controller", }, + { .compatible = "fsl,p1020-memory-controller", }, + { .compatible = "fsl,p1021-memory-controller", }, { .compatible = "fsl,p2020-memory-controller", }, + { .compatible = "fsl,p4080-memory-controller", }, {}, }; -- 1.7.0.5 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers 2010-07-15 18:25 [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers Anton Vorontsov @ 2010-07-16 20:12 ` Scott Wood 2010-07-21 22:39 ` Andrew Morton 0 siblings, 1 reply; 11+ messages in thread From: Scott Wood @ 2010-07-16 20:12 UTC (permalink / raw) To: Anton Vorontsov Cc: Peter Tyser, linux-kernel, Dave Jiang, linuxppc-dev, Doug Thompson, Andrew Morton On Thu, 15 Jul 2010 22:25:07 +0400 Anton Vorontsov <avorontsov@mvista.com> wrote: > Simply add proper IDs into the device table. > > Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> > --- > > It appears that the driver has two device ID tables. :-) > So, my previous attempt enabled only half of the functionality. > > Andrew, > > Can you please replace > > edac-mpc85xx-add-support-for-mpc8569-edac-controllers.patch > > with this patch? It also adds some more IDs for the newer chips. > > Thanks! > > drivers/edac/mpc85xx_edac.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index 52ca09b..3820879 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -646,8 +646,12 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { > { .compatible = "fsl,mpc8555-l2-cache-controller", }, > { .compatible = "fsl,mpc8560-l2-cache-controller", }, > { .compatible = "fsl,mpc8568-l2-cache-controller", }, > + { .compatible = "fsl,mpc8569-l2-cache-controller", }, > { .compatible = "fsl,mpc8572-l2-cache-controller", }, > + { .compatible = "fsl,p1020-l2-cache-controller", }, > + { .compatible = "fsl,p1021-l2-cache-controller", }, > { .compatible = "fsl,p2020-l2-cache-controller", }, > + { .compatible = "fsl,p4080-l2-cache-controller", }, L2 on the p4080 is quite different from those other chips. It's part of the core, controlled by SPRs. -Scott ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers 2010-07-16 20:12 ` Scott Wood @ 2010-07-21 22:39 ` Andrew Morton 2010-07-21 23:21 ` Scott Wood 0 siblings, 1 reply; 11+ messages in thread From: Andrew Morton @ 2010-07-21 22:39 UTC (permalink / raw) To: Scott Wood Cc: Peter Tyser, Anton Vorontsov, linux-kernel, Dave Jiang, linuxppc-dev, Doug Thompson On Fri, 16 Jul 2010 15:12:24 -0500 Scott Wood <scottwood@freescale.com> wrote: > On Thu, 15 Jul 2010 22:25:07 +0400 > Anton Vorontsov <avorontsov@mvista.com> wrote: > > > Simply add proper IDs into the device table. > > > > Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> > > --- > > > > It appears that the driver has two device ID tables. :-) > > So, my previous attempt enabled only half of the functionality. > > > > Andrew, > > > > Can you please replace > > > > edac-mpc85xx-add-support-for-mpc8569-edac-controllers.patch > > > > with this patch? It also adds some more IDs for the newer chips. > > edac-mpc85xx-add-support-for-mpc8569-edac-controllers.patch already got itself merged. I queued this: --- a/drivers/edac/mpc85xx_edac.c~edac-mpc85xx-add-support-for-new-mpcxxx-pxxxx-edac-controllers +++ a/drivers/edac/mpc85xx_edac.c @@ -646,8 +646,12 @@ static struct of_device_id mpc85xx_l2_er { .compatible = "fsl,mpc8555-l2-cache-controller", }, { .compatible = "fsl,mpc8560-l2-cache-controller", }, { .compatible = "fsl,mpc8568-l2-cache-controller", }, + { .compatible = "fsl,mpc8569-l2-cache-controller", }, { .compatible = "fsl,mpc8572-l2-cache-controller", }, + { .compatible = "fsl,p1020-l2-cache-controller", }, + { .compatible = "fsl,p1021-l2-cache-controller", }, { .compatible = "fsl,p2020-l2-cache-controller", }, + { .compatible = "fsl,p4080-l2-cache-controller", }, {}, }; @@ -1123,7 +1127,10 @@ static struct of_device_id mpc85xx_mc_er { .compatible = "fsl,mpc8569-memory-controller", }, { .compatible = "fsl,mpc8572-memory-controller", }, { .compatible = "fsl,mpc8349-memory-controller", }, + { .compatible = "fsl,p1020-memory-controller", }, + { .compatible = "fsl,p1021-memory-controller", }, { .compatible = "fsl,p2020-memory-controller", }, + { .compatible = "fsl,p4080-memory-controller", }, {}, }; _ > > > > drivers/edac/mpc85xx_edac.c | 8 ++++++++ > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > > index 52ca09b..3820879 100644 > > --- a/drivers/edac/mpc85xx_edac.c > > +++ b/drivers/edac/mpc85xx_edac.c > > @@ -646,8 +646,12 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { > > { .compatible = "fsl,mpc8555-l2-cache-controller", }, > > { .compatible = "fsl,mpc8560-l2-cache-controller", }, > > { .compatible = "fsl,mpc8568-l2-cache-controller", }, > > + { .compatible = "fsl,mpc8569-l2-cache-controller", }, > > { .compatible = "fsl,mpc8572-l2-cache-controller", }, > > + { .compatible = "fsl,p1020-l2-cache-controller", }, > > + { .compatible = "fsl,p1021-l2-cache-controller", }, > > { .compatible = "fsl,p2020-l2-cache-controller", }, > > + { .compatible = "fsl,p4080-l2-cache-controller", }, > > L2 on the p4080 is quite different from those other chips. It's part > of the core, controlled by SPRs. erm, was that an ack or a nack? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers 2010-07-21 22:39 ` Andrew Morton @ 2010-07-21 23:21 ` Scott Wood 2010-08-01 10:54 ` [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Anton Vorontsov 0 siblings, 1 reply; 11+ messages in thread From: Scott Wood @ 2010-07-21 23:21 UTC (permalink / raw) To: Andrew Morton Cc: Peter Tyser, Anton Vorontsov, linux-kernel, Dave Jiang, linuxppc-dev, Doug Thompson On Wed, 21 Jul 2010 15:39:33 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > On Fri, 16 Jul 2010 15:12:24 -0500 > Scott Wood <scottwood@freescale.com> wrote: > > > > > > > drivers/edac/mpc85xx_edac.c | 8 ++++++++ > > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > > > index 52ca09b..3820879 100644 > > > --- a/drivers/edac/mpc85xx_edac.c > > > +++ b/drivers/edac/mpc85xx_edac.c > > > @@ -646,8 +646,12 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { > > > { .compatible = "fsl,mpc8555-l2-cache-controller", }, > > > { .compatible = "fsl,mpc8560-l2-cache-controller", }, > > > { .compatible = "fsl,mpc8568-l2-cache-controller", }, > > > + { .compatible = "fsl,mpc8569-l2-cache-controller", }, > > > { .compatible = "fsl,mpc8572-l2-cache-controller", }, > > > + { .compatible = "fsl,p1020-l2-cache-controller", }, > > > + { .compatible = "fsl,p1021-l2-cache-controller", }, > > > { .compatible = "fsl,p2020-l2-cache-controller", }, > > > + { .compatible = "fsl,p4080-l2-cache-controller", }, > > > > L2 on the p4080 is quite different from those other chips. It's part > > of the core, controlled by SPRs. > > erm, was that an ack or a nack? NACK, p4080 doesn't belong in this table, at least not its L2. L3 on p4080 is similar to L2 on these other chips, though, and it wouldn't take much to get this driver working on it -- but the match table entry should wait until the differences are accommodated. -Scott ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-07-21 23:21 ` Scott Wood @ 2010-08-01 10:54 ` Anton Vorontsov 2010-10-07 6:18 ` Kumar Gala 0 siblings, 1 reply; 11+ messages in thread From: Anton Vorontsov @ 2010-08-01 10:54 UTC (permalink / raw) To: Andrew Morton, Scott Wood Cc: linuxppc-dev, Peter Tyser, Doug Thompson, linux-kernel, Dave Jiang On Wed, Jul 21, 2010 at 06:21:08PM -0500, Scott Wood wrote: [...] > > > > + { .compatible = "fsl,p4080-l2-cache-controller", }, > > > > > > L2 on the p4080 is quite different from those other chips. It's part > > > of the core, controlled by SPRs. > > > > erm, was that an ack or a nack? > > NACK, p4080 doesn't belong in this table, at least not its L2. > > L3 on p4080 is similar to L2 on these other chips, though, and it > wouldn't take much to get this driver working on it -- but the match > table entry should wait until the differences are accommodated. Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> --- Scott, thanks for catching this! Andrew, please merge this patch into edac-mpc85xx-add-support-for-new-mpcxxx-pxxxx-edac-controllers.patch Thanks! drivers/edac/mpc85xx_edac.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index cfa86f7..b178cfa 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -652,7 +652,6 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { { .compatible = "fsl,p1020-l2-cache-controller", }, { .compatible = "fsl,p1021-l2-cache-controller", }, { .compatible = "fsl,p2020-l2-cache-controller", }, - { .compatible = "fsl,p4080-l2-cache-controller", }, {}, }; MODULE_DEVICE_TABLE(of, mpc85xx_l2_err_of_match); -- 1.7.0.5 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-08-01 10:54 ` [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Anton Vorontsov @ 2010-10-07 6:18 ` Kumar Gala 2010-10-07 6:29 ` Anton Vorontsov 0 siblings, 1 reply; 11+ messages in thread From: Kumar Gala @ 2010-10-07 6:18 UTC (permalink / raw) To: Anton Vorontsov Cc: linuxppc-dev, linux-kernel, Dave Jiang, Peter Tyser, Doug Thompson, Scott Wood, Andrew Morton On Aug 1, 2010, at 5:54 AM, Anton Vorontsov wrote: > On Wed, Jul 21, 2010 at 06:21:08PM -0500, Scott Wood wrote: > [...] >>>>> + { .compatible =3D "fsl,p4080-l2-cache-controller", }, >>>>=20 >>>> L2 on the p4080 is quite different from those other chips. It's = part >>>> of the core, controlled by SPRs. >>>=20 >>> erm, was that an ack or a nack? >>=20 >> NACK, p4080 doesn't belong in this table, at least not its L2. >>=20 >> L3 on p4080 is similar to L2 on these other chips, though, and it >> wouldn't take much to get this driver working on it -- but the match >> table entry should wait until the differences are accommodated. >=20 > Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> > --- >=20 > Scott, thanks for catching this! >=20 > Andrew, please merge this patch into > edac-mpc85xx-add-support-for-new-mpcxxx-pxxxx-edac-controllers.patch >=20 > Thanks! >=20 > drivers/edac/mpc85xx_edac.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) >=20 > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index cfa86f7..b178cfa 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -652,7 +652,6 @@ static struct of_device_id = mpc85xx_l2_err_of_match[] =3D { > { .compatible =3D "fsl,p1020-l2-cache-controller", }, > { .compatible =3D "fsl,p1021-l2-cache-controller", }, > { .compatible =3D "fsl,p2020-l2-cache-controller", }, > - { .compatible =3D "fsl,p4080-l2-cache-controller", }, > {}, > }; > MODULE_DEVICE_TABLE(of, mpc85xx_l2_err_of_match); > --=20 > 1.7.0.5 Can you post a new patch as it doesn't look like this got merged by = Andrew so we need to clean up after ourselves. - k ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-10-07 6:18 ` Kumar Gala @ 2010-10-07 6:29 ` Anton Vorontsov 2010-10-07 6:37 ` Kumar Gala 0 siblings, 1 reply; 11+ messages in thread From: Anton Vorontsov @ 2010-10-07 6:29 UTC (permalink / raw) To: Kumar Gala Cc: linuxppc-dev, linux-kernel, Dave Jiang, Peter Tyser, Doug Thompson, Scott Wood, Andrew Morton On Thu, Oct 07, 2010 at 01:18:19AM -0500, Kumar Gala wrote: [...] > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > > index cfa86f7..b178cfa 100644 > > --- a/drivers/edac/mpc85xx_edac.c > > +++ b/drivers/edac/mpc85xx_edac.c > > @@ -652,7 +652,6 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { > > { .compatible = "fsl,p1020-l2-cache-controller", }, > > { .compatible = "fsl,p1021-l2-cache-controller", }, > > { .compatible = "fsl,p2020-l2-cache-controller", }, > > - { .compatible = "fsl,p4080-l2-cache-controller", }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, mpc85xx_l2_err_of_match); > > -- > > 1.7.0.5 > > Can you post a new patch as it doesn't look like this got merged by Andrew so we need to clean up after ourselves. It's already in Linus' tree. Thanks, - - - - commit cd1542c8197fc3c2eb3a8301505d5d9738fab1e4 Author: Anton Vorontsov <avorontsov@mvista.com> Date: Tue Aug 10 18:03:21 2010 -0700 edac: mpc85xx: add support for new MPCxxx/Pxxxx EDAC controllers Simply add proper IDs into the device table. Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> Cc: Scott Wood <scottwood@freescale.com> Cc: Peter Tyser <ptyser@xes-inc.com> Cc: Dave Jiang <djiang@mvista.com> Cc: Doug Thompson <dougthompson@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index fdbad55..af75e27 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -647,7 +647,10 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = { { .compatible = "fsl,mpc8555-l2-cache-controller", }, { .compatible = "fsl,mpc8560-l2-cache-controller", }, { .compatible = "fsl,mpc8568-l2-cache-controller", }, + { .compatible = "fsl,mpc8569-l2-cache-controller", }, { .compatible = "fsl,mpc8572-l2-cache-controller", }, + { .compatible = "fsl,p1020-l2-cache-controller", }, + { .compatible = "fsl,p1021-l2-cache-controller", }, { .compatible = "fsl,p2020-l2-cache-controller", }, {}, }; @@ -1125,7 +1128,10 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = { { .compatible = "fsl,mpc8569-memory-controller", }, { .compatible = "fsl,mpc8572-memory-controller", }, { .compatible = "fsl,mpc8349-memory-controller", }, + { .compatible = "fsl,p1020-memory-controller", }, + { .compatible = "fsl,p1021-memory-controller", }, { .compatible = "fsl,p2020-memory-controller", }, + { .compatible = "fsl,p4080-memory-controller", }, {}, }; MODULE_DEVICE_TABLE(of, mpc85xx_mc_err_of_match); ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-10-07 6:29 ` Anton Vorontsov @ 2010-10-07 6:37 ` Kumar Gala 2010-10-07 7:00 ` Kumar Gala 0 siblings, 1 reply; 11+ messages in thread From: Kumar Gala @ 2010-10-07 6:37 UTC (permalink / raw) To: Anton Vorontsov Cc: linuxppc-dev, linux-kernel, Dave Jiang, Peter Tyser, Doug Thompson, Scott Wood, Andrew Morton >=20 > It's already in Linus' tree. Yeah, the problem is what's merged in linus's tree has p4080 listed and = it shouldn't >=20 > Thanks, >=20 > - - - - > commit cd1542c8197fc3c2eb3a8301505d5d9738fab1e4 > Author: Anton Vorontsov <avorontsov@mvista.com> > Date: Tue Aug 10 18:03:21 2010 -0700 >=20 > edac: mpc85xx: add support for new MPCxxx/Pxxxx EDAC controllers >=20 > Simply add proper IDs into the device table. >=20 > Signed-off-by: Anton Vorontsov <avorontsov@mvista.com> > Cc: Scott Wood <scottwood@freescale.com> > Cc: Peter Tyser <ptyser@xes-inc.com> > Cc: Dave Jiang <djiang@mvista.com> > Cc: Doug Thompson <dougthompson@xmission.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> >=20 > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index fdbad55..af75e27 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -647,7 +647,10 @@ static struct of_device_id = mpc85xx_l2_err_of_match[] =3D { > { .compatible =3D "fsl,mpc8555-l2-cache-controller", }, > { .compatible =3D "fsl,mpc8560-l2-cache-controller", }, > { .compatible =3D "fsl,mpc8568-l2-cache-controller", }, > + { .compatible =3D "fsl,mpc8569-l2-cache-controller", }, > { .compatible =3D "fsl,mpc8572-l2-cache-controller", }, > + { .compatible =3D "fsl,p1020-l2-cache-controller", }, > + { .compatible =3D "fsl,p1021-l2-cache-controller", }, > { .compatible =3D "fsl,p2020-l2-cache-controller", }, > {}, > }; > @@ -1125,7 +1128,10 @@ static struct of_device_id = mpc85xx_mc_err_of_match[] =3D { > { .compatible =3D "fsl,mpc8569-memory-controller", }, > { .compatible =3D "fsl,mpc8572-memory-controller", }, > { .compatible =3D "fsl,mpc8349-memory-controller", }, > + { .compatible =3D "fsl,p1020-memory-controller", }, > + { .compatible =3D "fsl,p1021-memory-controller", }, > { .compatible =3D "fsl,p2020-memory-controller", }, > + { .compatible =3D "fsl,p4080-memory-controller", }, This line should be here ;) > {}, > }; > MODULE_DEVICE_TABLE(of, mpc85xx_mc_err_of_match); ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-10-07 6:37 ` Kumar Gala @ 2010-10-07 7:00 ` Kumar Gala 2010-10-07 7:12 ` Anton Vorontsov 0 siblings, 1 reply; 11+ messages in thread From: Kumar Gala @ 2010-10-07 7:00 UTC (permalink / raw) To: Kumar Gala Cc: linuxppc-dev, Doug Thompson, linux-kernel, Dave Jiang, Peter Tyser, Scott Wood, Andrew Morton On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote: >> @ -1125,7 +1128,10 @@ static struct of_device_id = mpc85xx_mc_err_of_match[] =3D { >> { .compatible =3D "fsl,mpc8569-memory-controller", }, >> { .compatible =3D "fsl,mpc8572-memory-controller", }, >> { .compatible =3D "fsl,mpc8349-memory-controller", }, >> + { .compatible =3D "fsl,p1020-memory-controller", }, >> + { .compatible =3D "fsl,p1021-memory-controller", }, >> { .compatible =3D "fsl,p2020-memory-controller", }, >> + { .compatible =3D "fsl,p4080-memory-controller", }, >=20 > This line should be here ;) should NOT be here. - k= ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-10-07 7:00 ` Kumar Gala @ 2010-10-07 7:12 ` Anton Vorontsov 2010-10-07 13:21 ` Kumar Gala 0 siblings, 1 reply; 11+ messages in thread From: Anton Vorontsov @ 2010-10-07 7:12 UTC (permalink / raw) To: Kumar Gala Cc: linuxppc-dev, linux-kernel, Dave Jiang, Peter Tyser, Doug Thompson, Scott Wood, Andrew Morton On Thu, Oct 07, 2010 at 02:00:50AM -0500, Kumar Gala wrote: > > On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote: > > >> @ -1125,7 +1128,10 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = { > >> { .compatible = "fsl,mpc8569-memory-controller", }, > >> { .compatible = "fsl,mpc8572-memory-controller", }, > >> { .compatible = "fsl,mpc8349-memory-controller", }, > >> + { .compatible = "fsl,p1020-memory-controller", }, > >> + { .compatible = "fsl,p1021-memory-controller", }, > >> { .compatible = "fsl,p2020-memory-controller", }, > >> + { .compatible = "fsl,p4080-memory-controller", }, > > > > This line should be here ;) > > should NOT be here. Hm. Are you sure? I thought that only L2 cache controller is not applicable (and based on Scott's comment I removed the l2 cache compatible entry for p4080). But I guess memory-controller is somewhat similar to all other 85xx? If it's not, I can surely prepare a patch that removes p4080 entry. Thanks, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) 2010-10-07 7:12 ` Anton Vorontsov @ 2010-10-07 13:21 ` Kumar Gala 0 siblings, 0 replies; 11+ messages in thread From: Kumar Gala @ 2010-10-07 13:21 UTC (permalink / raw) To: Anton Vorontsov Cc: linuxppc-dev, linux-kernel, Dave Jiang, Peter Tyser, Doug Thompson, Scott Wood, Andrew Morton On Oct 7, 2010, at 2:12 AM, Anton Vorontsov wrote: > On Thu, Oct 07, 2010 at 02:00:50AM -0500, Kumar Gala wrote: >>=20 >> On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote: >>=20 >>>> @ -1125,7 +1128,10 @@ static struct of_device_id = mpc85xx_mc_err_of_match[] =3D { >>>> { .compatible =3D "fsl,mpc8569-memory-controller", }, >>>> { .compatible =3D "fsl,mpc8572-memory-controller", }, >>>> { .compatible =3D "fsl,mpc8349-memory-controller", }, >>>> + { .compatible =3D "fsl,p1020-memory-controller", }, >>>> + { .compatible =3D "fsl,p1021-memory-controller", }, >>>> { .compatible =3D "fsl,p2020-memory-controller", }, >>>> + { .compatible =3D "fsl,p4080-memory-controller", }, >>>=20 >>> This line should be here ;) >>=20 >> should NOT be here. >=20 > Hm. Are you sure? I thought that only L2 cache controller is > not applicable (and based on Scott's comment I removed > the l2 cache compatible entry for p4080). But I guess > memory-controller is somewhat similar to all other 85xx? >=20 > If it's not, I can surely prepare a patch that removes > p4080 entry. >=20 > Thanks, Your correct, late night and looking at the wrong line. It was the L2 = that should have been removed. Ignore me. - k= ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-10-07 13:22 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-07-15 18:25 [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers Anton Vorontsov 2010-07-16 20:12 ` Scott Wood 2010-07-21 22:39 ` Andrew Morton 2010-07-21 23:21 ` Scott Wood 2010-08-01 10:54 ` [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Anton Vorontsov 2010-10-07 6:18 ` Kumar Gala 2010-10-07 6:29 ` Anton Vorontsov 2010-10-07 6:37 ` Kumar Gala 2010-10-07 7:00 ` Kumar Gala 2010-10-07 7:12 ` Anton Vorontsov 2010-10-07 13:21 ` Kumar Gala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).