From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk (caramon.arm.linux.org.uk [78.32.30.218]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BAE75B6F16 for ; Sat, 17 Jul 2010 04:30:47 +1000 (EST) Date: Fri, 16 Jul 2010 19:30:28 +0100 From: Russell King - ARM Linux To: Nicolas Pitre Subject: Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig Message-ID: <20100716183028.GB26854@n2100.arm.linux.org.uk> References: <20100713230352.6781.18644.stgit@angua> <1279296221.17878.66.camel@e102109-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: Russell King - ARM Linux Cc: Stephen Rothwell , Daniel Walker , linux-kbuild@vger.kernel.org, Tony Lindgren , Catalin Marinas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, Linus Torvalds , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jul 16, 2010 at 02:19:31PM -0400, Nicolas Pitre wrote: > For example, if I want CONFIG_MTD_CMDLINE_PARTS=y, the system may be > smart enough to notice and automatically enable CONFIG_MTD and > CONFIG_MTD_PARTITIONS without having to carry those in the defconfig. How do you sort out something like this: config FOO bool "Foo" depends on (A && B) || C Do you enable A and B, A, B and C or just C? Bear in mind that A could be 'X86', 'M68K' or any other arch specific symbol. I prefer the warning method because it prompts you to investigate what's changed and sort out the problem by ensuring that the appropriate symbols are also selected. The automatic selection of dependencies method carries the risk that it'll do the wrong thing with the above scenario.