From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: sachinp@linux.vnet.ibm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
ossthema@de.ibm.com, dipraksh@linux.vnet.ibm.com
Subject: Re: Badness with the kernel version 2.6.35-rc1-git1 running on P6 box
Date: Sun, 18 Jul 2010 14:51:20 -0700 (PDT) [thread overview]
Message-ID: <20100718.145120.35845833.davem@davemloft.net> (raw)
In-Reply-To: <1279282842.2549.16.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 Jul 2010 14:20:42 +0200
> Le vendredi 16 juillet 2010 =E0 11:56 +0200, Eric Dumazet a =E9crit :=
> =
>> [PATCH] ehea: ehea_get_stats() should use GFP_KERNEL
>> =
>> ehea_get_stats() is called in process context and should use GFP_KER=
NEL
>> allocation instead of GFP_ATOMIC.
>> =
>> Clearing stats at beginning of ehea_get_stats() is racy in case of
>> concurrent stat readers.
>> =
>> get_stats() can also use netdev net_device_stats, instead of a priva=
te
>> copy.
>> =
>> Reported-by: divya <dipraksh@linux.vnet.ibm.com>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>> ---
>> drivers/net/ehea/ehea.h | 1 -
>> drivers/net/ehea/ehea_main.c | 6 ++----
>> 2 files changed, 2 insertions(+), 5 deletions(-)
>> =
>> =
> =
> Hmm, net-next-2.6 contains following patch :
If people think ehea usage is ubiquitous enough to deserve a backport
of this to net-2.6, fine. But personally I don't think it's worth it.
Can someone close the kernel bugzilla 16406 created for this bug? This=
patch we have already obviously would fix this issue.
next prev parent reply other threads:[~2010-07-18 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 8:50 Badness with the kernel version 2.6.35-rc1-git1 running on P6 box divya
2010-07-16 9:56 ` Eric Dumazet
2010-07-16 12:20 ` Eric Dumazet
2010-07-18 21:51 ` David Miller [this message]
2010-07-16 17:35 ` Dave Hansen
2010-07-16 19:19 ` David Rientjes
2010-07-20 9:05 ` divya
2010-07-17 5:52 ` Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100718.145120.35845833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dipraksh@linux.vnet.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).