From: David Miller <davem@davemloft.net>
To: mikpe@it.uu.se
Cc: linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] math-emu: correct test for downshifting fraction in _FP_FROM_INT()
Date: Tue, 20 Jul 2010 18:45:48 -0700 (PDT) [thread overview]
Message-ID: <20100720.184548.250802682.davem@davemloft.net> (raw)
In-Reply-To: <19524.51858.992299.119315@pilspetsen.it.uu.se>
From: Mikael Pettersson <mikpe@it.uu.se>
Date: Mon, 19 Jul 2010 23:58:42 +0200
> The kernel's math-emu code contains a macro _FP_FROM_INT() which is
> used to convert an integer to a raw normalized floating-point value.
> It does this basically in three steps:
...
> The fix is simple: the exponent comparison used to determine if the
> fraction should be downshifted must be "<=" not "<".
>
> I'm sending a kernel module to test this as a reply to this message.
> There are also SPARC user-space test cases in the GCC bug entry.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Applied and I'll make sure this gets into -stable too.
Thanks!
prev parent reply other threads:[~2010-07-21 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 21:58 [PATCH] math-emu: correct test for downshifting fraction in _FP_FROM_INT() Mikael Pettersson
2010-07-19 22:12 ` Mikael Pettersson
2010-07-20 7:34 ` Martin Schwidefsky
2010-07-19 22:12 ` David Miller
2010-07-20 13:35 ` Mikael Pettersson
2010-07-21 1:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720.184548.250802682.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikpe@it.uu.se \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).