linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: Bradley Hughes <bhughes@silicontkx.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 0/2] Adding DTS for the STx GP3-SSA MPC8555 board
Date: Thu, 22 Jul 2010 00:47:02 +0200	[thread overview]
Message-ID: <20100721224702.89A12153A7F@gemini.denx.de> (raw)
In-Reply-To: <AANLkTimMb_PshxAIDvbfFdbCqHrlY13Qiz9g2eZ1vw1E@mail.gmail.com>

Dear Bradley Hughes,

In message <AANLkTimMb_PshxAIDvbfFdbCqHrlY13Qiz9g2eZ1vw1E@mail.gmail.com> you wrote:
> This version uses "fsl,mpc8555..." instead of "fsl,85..." notation.

Such comments should go below the "---" line.

> There is also an 8541 version of this board so DTS for this board
> is specific to the 8555 processor.
> 
> Another patch is coming to fix-up other DTS that use old notation.

Ditto.

> Signed-off-by: Bradley Hughes <bhughes@silicontkx.com>
> ---
^^^^^^^  Insert comments after this line.

Hm... have you verified that PCI is working? I tried enabling drivers
for the ITE8211 PATA controller, but it doesn't seem to work for me
(and yes, I did add the required "pata_it821x.noraid=1" to the
bootargs).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
To be a winner, all you need to give is all you have.

  reply	other threads:[~2010-07-21 22:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21 22:04 [PATCH v2 0/2] Adding DTS for the STx GP3-SSA MPC8555 board Bradley Hughes
2010-07-21 22:47 ` Wolfgang Denk [this message]
2010-08-04 19:23 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100721224702.89A12153A7F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=bhughes@silicontkx.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).