Re: [PATCH 1/3] mmc: Auto CMD12 support for eSDHC driver

[Anton Vorontsov <cbouatmailru@gmail.com>]

On Wed, Jul 28, 2010 at 01:42:33PM +0800, Roy Zang wrote:
[...]
> +	if (host->quirks & SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12)
> +		if (mrq->stop) {
> +			mrq->data->stop = NULL;
> +			mrq->stop = NULL;
> +		}

Please put additional curly braces for the first 'if' statement.

>  	host->mrq = mrq;
>  
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index c846813..aa112aa 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -2,6 +2,7 @@
>   *  linux/drivers/mmc/host/sdhci.h - Secure Digital Host Controller Interface driver
>   *
>   *  Copyright (C) 2005-2008 Pierre Ossman, All Rights Reserved.
> + * Copyright 2010 Freescale Semiconductor, Inc.

Wrong count of spaces after '*'.

Also, according to git shortlog it's Freescale's first
patch to sdhci core, and the patch is quite trivial.

IANAL, but please refrain from adding authorship or copyright
notices unless you have done some major contribution(s).

>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> @@ -240,6 +241,8 @@ struct sdhci_host {
>  #define SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN		(1<<25)
>  /* Controller cannot support End Attribute in NOP ADMA descriptor */
>  #define SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC		(1<<26)
> +/* Controller uses Auto CMD12 command to stop the transfer */
> +#define SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12		(1<<27)

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2