From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, linux-usb@vger.kernel.org,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Dinh Nguyen <Dinh.Nguyen@freescale.com>
Subject: Re: [PATCH 2/7] usb: fsl_udc_core: check return value of create_proc_read_entry()
Date: Sat, 31 Jul 2010 21:17:43 +0200 [thread overview]
Message-ID: <20100731191743.GF26313@bicker> (raw)
In-Reply-To: <1280597900-8405-1-git-send-email-segooon@gmail.com>
On Sat, Jul 31, 2010 at 09:38:20PM +0400, Kulikov Vasiliy wrote:
> create_proc_read_entry() may fail, if so return -ENOMEM.
>
It can fail, but also we return NULL if procfs is disabled. I haven't
looked at it very carefully, would this patch break the module if procfs
was disabled?
The same applies to the similar patches in this set.
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-31 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 17:38 [PATCH 2/7] usb: fsl_udc_core: check return value of create_proc_read_entry() Kulikov Vasiliy
2010-07-31 19:17 ` Dan Carpenter [this message]
2010-08-01 6:19 ` Vasiliy Kulikov
2010-08-01 10:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100731191743.GF26313@bicker \
--to=error27@gmail.com \
--cc=Dinh.Nguyen@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).