From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from coco.kroah.org (kroah.org [198.145.64.141]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "coco.kroah.org", Issuer "Greg KH" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 31D1DB70B4 for ; Tue, 3 Aug 2010 09:14:32 +1000 (EST) Date: Mon, 2 Aug 2010 16:01:34 -0700 From: Greg KH To: Greg KH Subject: Re: [PATCH 2/3] USB: add of_platform glue driver for FSL USB DR controller Message-ID: <20100802230134.GB28463@kroah.com> References: <1279815922-27198-1-git-send-email-agust@denx.de> <1279815922-27198-3-git-send-email-agust@denx.de> <20100728135858.5dc14484@wker> <20100728184647.GA7128@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100728184647.GA7128@suse.de> Cc: David Brownell , Wolfgang Denk , Detlev Zundel , linux-usb@vger.kernel.org, linuxppc-dev@ozlabs.org, Anatolij Gustschin List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jul 28, 2010 at 11:46:47AM -0700, Greg KH wrote: > On Wed, Jul 28, 2010 at 12:14:14PM -0600, Grant Likely wrote: > > On Wed, Jul 28, 2010 at 5:58 AM, Anatolij Gustschin wrote: > > > Hi Grant, > > > > > > On Wed, 28 Jul 2010 02:16:08 -0600 > > > Grant Likely wrote: > > > > > >> On Thu, Jul 22, 2010 at 10:25 AM, Anatolij Gustschin wrote: > > >> > The driver creates platform devices based on the information > > >> > from USB nodes in the flat device tree. This is the replacement > > >> > for old arch fsl_soc usb code removed by the previous patch. > > >> > It uses usual of-style binding, available EHCI-HCD and UDC > > >> > drivers can be bound to the created devices. The new of-style > > >> > driver additionaly instantiates USB OTG platform device, as the > > >> > appropriate USB OTG driver will be added soon. > > >> > > > >> > Signed-off-by: Anatolij Gustschin > > >> > Cc: Kumar Gala > > >> > Cc: Grant Likely > > >> > > >> Hi Anatolij, > > >> > > >> Looks pretty good, but some comments below. > > > > > > Thanks for review and comments! Greg already merged this series and > > > therefore I'll submit an incremental cleanup patch to address > > > outstanding issues. My reply is below. > > > > Greg maintains a patchwork tree IIRC. I believe he drops patches from > > his linux-next branch if they need to be reworked. Greg, do I have > > this right? > > Yup. I can easily drop all of these patches. > > > Also, my preference would be to see some 3rd party testing before > > committing to having this merged. > > Ok, I will go drop them all now, and wait for some that pass your > review. All 3 now dropped. thanks, greg k-h