From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-px0-f179.google.com (mail-px0-f179.google.com [209.85.212.179]) by ozlabs.org (Postfix) with ESMTP id 2C544B711B for ; Tue, 31 Aug 2010 18:03:48 +1000 (EST) Received: by pxi14 with SMTP id 14so2938408pxi.38 for ; Tue, 31 Aug 2010 01:03:46 -0700 (PDT) Sender: Grant Likely Date: Tue, 31 Aug 2010 02:03:44 -0600 From: Grant Likely To: Anton Vorontsov Subject: Re: [PATCH] gpiolib: Add 'struct gpio_chip' forward declaration for !GPIOLIB case Message-ID: <20100831080344.GA20515@angua.secretlab.ca> References: <1282631168.22370.517.camel@pasglop> <20100824092623.GA20334@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20100824092623.GA20334@oksana.dev.rtsoft.ru> Cc: David Brownell , Andrew Morton , Benjamin Herrenschmidt , linuxppc-dev , linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 24, 2010 at 01:26:23PM +0400, Anton Vorontsov wrote: > With CONFIG_GPIOLIB=n, the 'struct gpio_chip' is not declared, > so the following pops up on PowerPC: > > cc1: warnings being treated as errors > In file included from arch/powerpc/platforms/52xx/mpc52xx_common.c:19: > include/linux/of_gpio.h:74: warning: 'struct gpio_chip' declared > inside parameter list > include/linux/of_gpio.h:74: warning: its scope is only this definition > or declaration, which is probably not what > you want > include/linux/of_gpio.h:75: warning: 'struct gpio_chip' declared > inside parameter list > make[2]: *** [arch/powerpc/platforms/52xx/mpc52xx_common.o] Error 1 > > This patch fixes the issue by providing the proper forward declaration. > > Signed-off-by: Anton Vorontsov This doesn't actually solve the problem, and gpiochip should remain undefined when CONFIG_GPIOLIB=n to catch exactly these build failures. The real problem is that I merged a change into the mpc5200 code that required CONFIG_GPIOLIB be enabled without reflecting that requirement in Kconfig. g. > --- > > On Tue, Aug 24, 2010 at 04:26:08PM +1000, Benjamin Herrenschmidt wrote: > > I get that with my current stuff: > > > > cc1: warnings being treated as errors > > In file included from [..]/mpc52xx_common.c:19: > > of_gpio.h:74: error: ‘struct gpio_chip’ declared inside parameter list > [...] > > make[3]: *** Waiting for unfinished jobs.... > > That's because with GPIOCHIP=n no one declares struct gpio_chip. > > It should be either of_gpio.h or gpio.h. Let's make it gpio.h, as > this feels more generic, and we already have some !GPIOLIB handling > in there. > > include/linux/gpio.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/linux/gpio.h b/include/linux/gpio.h > index 03f616b..85207d2 100644 > --- a/include/linux/gpio.h > +++ b/include/linux/gpio.h > @@ -15,6 +15,12 @@ > struct device; > > /* > + * Some code might rely on the declaration. Still, it is illegal > + * to dereference it for !GPIOLIB case. > + */ > +struct gpio_chip; > + > +/* > * Some platforms don't support the GPIO programming interface. > * > * In case some driver uses it anyway (it should normally have > -- > 1.7.0.5 >