From: David Miller <davem@davemloft.net>
To: grant.likely@secretlab.ca
Cc: netdev@vger.kernel.org, afleming@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: ERR_PTR pattern in phylib
Date: Wed, 01 Sep 2010 12:03:49 -0700 (PDT) [thread overview]
Message-ID: <20100901.120349.133893738.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTimkh6ytDmiCQY-gZLHpLzeux1RwMFyr=HyfcDaJ@mail.gmail.com>
From: Grant Likely <grant.likely@secretlab.ca>
Date: Wed, 1 Sep 2010 12:56:29 -0600
> The error codes in phylib are almost arbitrary and don't really give
> enough information about where the a failure lies. dev_err() is more
> useful for debugging.
If it's using bad error codes, that's only indicative of a bug in
phylib.
> How about this as a compromise: I'll investigate all the users of
> phylib and if I find even one situation where the specific return code
> is actually important to a driver, then I'll back off. phylib has
> been around for 5 years now which should be enough time for that use
> case to bubble to the surface.
Sorry, I'm not agreeable to this.
If there are bugs where drivers are not checking the return
pointers correctly, please just fix those bugs. Otherwise
I see things fine as they are.
next prev parent reply other threads:[~2010-09-01 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 14:42 ERR_PTR pattern in phylib Grant Likely
2010-09-01 15:27 ` David Miller
2010-09-01 18:56 ` Grant Likely
2010-09-01 19:03 ` David Miller [this message]
2010-09-01 15:50 ` Fleming Andy-AFLEMING
2010-09-02 15:20 ` Maciej W. Rozycki
2010-09-02 16:34 ` David Miller
2010-09-02 16:43 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901.120349.133893738.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).