From: David Miller <davem@davemloft.net>
To: macro@linux-mips.org
Cc: netdev@vger.kernel.org, afleming@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: ERR_PTR pattern in phylib
Date: Thu, 02 Sep 2010 09:34:51 -0700 (PDT) [thread overview]
Message-ID: <20100902.093451.189703514.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1009021617500.410@eddie.linux-mips.org>
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 2 Sep 2010 16:20:34 +0100 (BST)
> Arguably using a union here would make things cleaner and any reasonable
> ABI will place small unions used as arguments or return values in
> registers, but I'm not sure if the cost of the rewrite is worth the
Well, sparc 32-bit's ABI for one is "not reasonable" and these return
values will always get stack slots and passed back by reference.
next prev parent reply other threads:[~2010-09-02 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 14:42 ERR_PTR pattern in phylib Grant Likely
2010-09-01 15:27 ` David Miller
2010-09-01 18:56 ` Grant Likely
2010-09-01 19:03 ` David Miller
2010-09-01 15:50 ` Fleming Andy-AFLEMING
2010-09-02 15:20 ` Maciej W. Rozycki
2010-09-02 16:34 ` David Miller [this message]
2010-09-02 16:43 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902.093451.189703514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).