* Small issue at init with spi_mpc8xxx.c with CPM1
@ 2010-09-07 9:17 LEROY Christophe
2010-09-07 20:00 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: LEROY Christophe @ 2010-09-07 9:17 UTC (permalink / raw)
To: Kumar Gala; +Cc: LinuxPPC-dev
Dear Kumar,
I have a small issue in the init of spi_mpc8xxx.c with MPC866 (CPM1)
Unlike cpm_uart that maps the parameter ram directly using
of_iomap(np,1), spi_mpc8xxx.c uses cpm_muram_alloc_fixed().
This has two impacts in the .dts file:
* The driver must be declared with pram at 1d80 instead of 3d80 whereas
it is not a child of muram@2000 but a child of cpm@9c0
* muram@2000/data@0 must be declared with reg = <0x0 0x2000> whereas
is should be reg=<0x0 0x1c00> to avoid cpm_muram_alloc() to allocate
space from parameters ram.
Maybe I misunderstood something ?
Regards
Christophe Leroy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Small issue at init with spi_mpc8xxx.c with CPM1
2010-09-07 9:17 Small issue at init with spi_mpc8xxx.c with CPM1 LEROY Christophe
@ 2010-09-07 20:00 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2010-09-07 20:00 UTC (permalink / raw)
To: LEROY Christophe; +Cc: Kumar Gala, LinuxPPC-dev
On Tue, 7 Sep 2010 11:17:17 +0200
LEROY Christophe <christophe.leroy@c-s.fr> wrote:
>
> Dear Kumar,
>
> I have a small issue in the init of spi_mpc8xxx.c with MPC866 (CPM1)
>
> Unlike cpm_uart that maps the parameter ram directly using
> of_iomap(np,1), spi_mpc8xxx.c uses cpm_muram_alloc_fixed().
>
> This has two impacts in the .dts file:
> * The driver must be declared with pram at 1d80 instead of 3d80 whereas
> it is not a child of muram@2000 but a child of cpm@9c0
> * muram@2000/data@0 must be declared with reg = <0x0 0x2000> whereas
> is should be reg=<0x0 0x1c00> to avoid cpm_muram_alloc() to allocate
> space from parameters ram.
>
> Maybe I misunderstood something ?
Don't make the device tree lie, fix the driver instead.
The allocator should not be given any chunks of muram that are
dedicated to a fixed purpose -- it might hand it out to something else
before you reserve it. I don't think that cpm_muram_alloc_fixed() has
any legitimate use at all.
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-07 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-07 9:17 Small issue at init with spi_mpc8xxx.c with CPM1 LEROY Christophe
2010-09-07 20:00 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).