From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Olof Johansson <olof@lixom.net>
Cc: Tirumala Marri <tmarri@apm.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] APM821xx: Add support for new SoC APM821xx
Date: Mon, 13 Sep 2010 09:44:36 -0400 [thread overview]
Message-ID: <20100913134436.GA31548@zod.rchland.ibm.com> (raw)
In-Reply-To: <20100906154526.GA515@lixom.net>
On Mon, Sep 06, 2010 at 10:45:26AM -0500, Olof Johansson wrote:
>On Sun, Sep 05, 2010 at 10:19:53PM -0700, Tirumala Marri wrote:
>> >
>> > Then the device tree identifier, and the cpu setup functions, etc,
>> > should indicate
>> > 464, not APM821xx.
>> This is new SoC based on 464 cpu core. All the previous SoC device tree
>> CPU portion uses SoC name.
>
>Hm, you're right. Confusing.
>
>Still, the cpu setup functions would make more sense to have the core
>name in, not the SoC name. Especially since multiple SoC families might
>use the same core, etc.
In theory. In practice, it just makes it a damn mess. I'd rather leave
it as-is until we can get a good split-out of the core variants and what
their setup functions might require. Starting with just this SoC and not
fixing everything else is going to be confusing and probably wrong.
josh
prev parent reply other threads:[~2010-09-13 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 21:57 [PATCH] APM821xx: Add support for new SoC APM821xx tmarri
2010-09-03 2:08 ` Josh Boyer
2010-09-03 20:38 ` Tirumala Marri
2010-09-05 22:23 ` Olof Johansson
2010-09-06 5:19 ` Tirumala Marri
2010-09-06 14:15 ` Josh Boyer
2010-09-06 14:43 ` Tirumala Marri
2010-09-06 15:45 ` Olof Johansson
2010-09-08 17:27 ` Tirumala Marri
2010-09-13 13:44 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913134436.GA31548@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).