From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Peter Zijlstra <peterz@infradead.org>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: linux-next: build warnings after merge of the final tree (tip treee related)
Date: Wed, 15 Sep 2010 11:25:32 +0200 [thread overview]
Message-ID: <20100915092532.GH16593@elte.hu> (raw)
In-Reply-To: <20100915150047.42551e34.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Yinghai,
>
> On Tue, 14 Sep 2010 16:00:06 -0700 Yinghai Lu <yinghai@kernel.org> wrote:
> >
> > Also, we may need to remove all extern and __init and __initdata etc in .h files.
> >
> > please check
> >
> > [PATCH -v3] memblock: Fix section mismatch warning
> >
> > Use __init_memblock to replace __init, and remove __init in memblock.h
> >
> > -v2: more with memblock_is_meory()
> > -v3: remove __init for function declaring in memblock.h. Pointed out by Stephen.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Yinghai Lu <Yinghai@kernel.org>
>
> This version fixes all the warnings for me. So if you put the "extern"s
> back, you can add:
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Yinghai, mind posting the final version of the patch as a standalone
posting, with a proper changelog, and with the extern issue fixed as
well, plus all Reported-by and Tested-by tags added?
Thanks,
Ingo
next prev parent reply other threads:[~2010-09-15 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 3:27 linux-next: build warnings after merge of the final tree (tip treee related) Stephen Rothwell
2010-09-13 4:14 ` Yinghai Lu
2010-09-13 4:39 ` Stephen Rothwell
2010-09-13 8:24 ` Yinghai Lu
2010-09-14 4:50 ` Stephen Rothwell
2010-09-14 23:00 ` Yinghai Lu
2010-09-15 0:29 ` Stephen Rothwell
2010-09-15 1:33 ` Yinghai Lu
2010-09-15 4:39 ` Stephen Rothwell
2010-09-15 5:00 ` Stephen Rothwell
2010-09-15 9:25 ` Ingo Molnar [this message]
2010-09-15 20:05 ` [PATCH -v4] memblock: Fix section mismatch warnings Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915092532.GH16593@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).