linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Question on of_address_to_resource() with offset != 0
@ 2010-09-14 14:29 Stefan Roese
  2010-09-15 12:59 ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2010-09-14 14:29 UTC (permalink / raw)
  To: devicetree-discuss; +Cc: linuxppc-dev, Detlev Zundel

Hi,

I'm stumbling upon a problem noticed on the Ebony (440GP) eval board.
Here the first chip-select is connected to 512KiB of SRAM and 512KiB
NOR flash. The dts part look this way:

				small-flash@0,80000 {
					compatible = "jedec-flash";
					bank-width = <1>;
					reg = <0x00000000 0x00080000 0x00080000>;
					#address-cells = <1>;
					#size-cells = <1>;
					partition@0 {
						label = "OpenBIOS";
						reg = <0x00000000 0x00080000>;
						read-only;
					};
				};

Chip-select 0 has this setup:
base-addr = 0xfff00000, size = 0x100000 (phys addr 0x1fff00000 .. 0x1ffffffff)

The problem/crash happens in the physmap_of driver, when the the driver
calls do_map_probe() with the following range:
base-addr = 0xfff80000, size = 0x100000 (phys addr 0x1fff80000 .. 0x20007ffff)

My question now is, should of_address_to_resource() subtract the
offset (here 0x80000) from the size? Is this is bug here? Or should
the physmap_of driver take care of this issue somehow?

Cheers,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Question on of_address_to_resource() with offset != 0
  2010-09-14 14:29 Question on of_address_to_resource() with offset != 0 Stefan Roese
@ 2010-09-15 12:59 ` Stefan Roese
  2010-09-15 18:43   ` Grant Likely
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2010-09-15 12:59 UTC (permalink / raw)
  To: devicetree-discuss; +Cc: linuxppc-dev, Detlev Zundel

On Tuesday 14 September 2010 16:29:06 Stefan Roese wrote:
> I'm stumbling upon a problem noticed on the Ebony (440GP) eval board.
> Here the first chip-select is connected to 512KiB of SRAM and 512KiB
> NOR flash.

"Brown paper bag" time for me. Problem was located in U-Boot. Sorry for the 
noise.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Question on of_address_to_resource() with offset != 0
  2010-09-15 12:59 ` Stefan Roese
@ 2010-09-15 18:43   ` Grant Likely
  0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2010-09-15 18:43 UTC (permalink / raw)
  To: Stefan Roese; +Cc: devicetree-discuss, linuxppc-dev, Detlev Zundel

On Wed, Sep 15, 2010 at 02:59:42PM +0200, Stefan Roese wrote:
> On Tuesday 14 September 2010 16:29:06 Stefan Roese wrote:
> > I'm stumbling upon a problem noticed on the Ebony (440GP) eval board.
> > Here the first chip-select is connected to 512KiB of SRAM and 512KiB
> > NOR flash.
> 
> "Brown paper bag" time for me. Problem was located in U-Boot. Sorry for the 
> noise.

:-)

g.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-09-15 18:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-14 14:29 Question on of_address_to_resource() with offset != 0 Stefan Roese
2010-09-15 12:59 ` Stefan Roese
2010-09-15 18:43   ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).