linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Zang Roy-R61911 <r61911@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
	dedekind1@gmail.com, Lan Chunhe-B25806 <B25806@freescale.com>,
	linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
	akpm@linux-foundation.org, dwmw2@infradead.org,
	Gala Kumar-B11780 <B11780@freescale.com>
Subject: Re: [PATCH 2/3 v3] P4080/mtd: Only make elbc nand driver detect nand flash partitions
Date: Thu, 16 Sep 2010 14:14:29 +0400	[thread overview]
Message-ID: <20100916101429.GA27393@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <3850A844E6A3854C827AC5C0BEC7B60A1FC6DB@zch01exm23.fsl.freescale.net>

On Thu, Sep 16, 2010 at 06:08:14PM +0800, Zang Roy-R61911 wrote:
[...]
> Interesting.
> How about this?
> #include <stdio.h>
> #include <malloc.h>
> 
> char *foo;
> 
> void probe(void)
> {
>         char *bar = NULL;
> 
>         if (!foo) {
>                 bar = malloc(sizeof(*bar));
>                 if (!bar)
>                         return;
>                 foo = bar;
>         } else
> 		   bar = foo;

This willl work of course; but I'd write it as

foo_lock();
if (!foo)
	foo = alloc();
foo_unlock();

bar = foo;
bar->baz;

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2010-09-16 10:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16  6:41 [PATCH 1/3 v3] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Roy Zang
2010-09-16  6:41 ` [PATCH 2/3 v3] P4080/mtd: Only make elbc nand driver detect nand flash partitions Roy Zang
2010-09-16  6:41   ` [PATCH 3/3 v3] P4080/mtd: Fix the freescale lbc issue with 36bit mode Roy Zang
2010-09-16  7:31     ` Anton Vorontsov
2010-09-16  7:36       ` Zang Roy-R61911
2010-09-16  8:21   ` [PATCH 2/3 v3] P4080/mtd: Only make elbc nand driver detect nand flash partitions Anton Vorontsov
2010-09-16  8:50     ` Zang Roy-R61911
2010-09-16  9:25       ` Anton Vorontsov
2010-09-16 10:08         ` Zang Roy-R61911
2010-09-16 10:14           ` Anton Vorontsov [this message]
2010-09-16 10:39             ` Zang Roy-R61911
2010-09-16 11:26               ` Anton Vorontsov
2010-09-16 16:14                 ` Scott Wood
2010-09-16 16:40                   ` Anton Vorontsov
2010-09-16 16:53                     ` Scott Wood
2010-09-16  7:27 ` [PATCH 1/3 v3] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916101429.GA27393@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=B07421@freescale.com \
    --cc=B11780@freescale.com \
    --cc=B25806@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=r61911@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).