From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ew0-f42.google.com (mail-ew0-f42.google.com [209.85.215.42]) by ozlabs.org (Postfix) with ESMTP id 2A71DB6EF1 for ; Fri, 1 Oct 2010 01:06:41 +1000 (EST) Received: by ewy2 with SMTP id 2so1083484ewy.15 for ; Thu, 30 Sep 2010 08:06:40 -0700 (PDT) Date: Thu, 30 Sep 2010 19:06:33 +0400 From: Anton Vorontsov To: Grant Likely Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Message-ID: <20100930150633.GA13741@oksana.dev.rtsoft.ru> References: <841976.76219.qm@web180306.mail.gq1.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Cc: kumar.gala@freescale.com, David Brownell , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, spi-devel-general@lists.sourceforge.net, Mingkai Hu List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote: > On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely > wrote: > > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote: > >> > >> --- On Thu, 9/30/10, Mingkai Hu wrote: > >> > >>> From: Mingkai Hu > >>> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page > >> > >> NAK. > >> > >> We went over this before. > > > > Yes, I agree with David on this.  If large transfers don't work, then > > it is the SPI master driver that is buggy. > > By the way, does this fix your problem? > > https://patchwork.kernel.org/patch/184752/ It shouldn't. AFAIK, eSPI is PIO-only controller, and the overrun fix is for the DMA mode. Thanks, p.s. Btw, in patch 3/7, is_dma_mapped argument of fsl_espi_bufs() is unneeded. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2