From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Mingkai Hu <Mingkai.hu@freescale.com>
Cc: linuxppc-dev@ozlabs.org, kumar.gala@freescale.com,
linux-mtd@lists.infradead.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller
Date: Fri, 1 Oct 2010 15:22:12 +0400 [thread overview]
Message-ID: <20101001112212.GA17505@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1285833646-12006-3-git-send-email-Mingkai.hu@freescale.com>
On Thu, Sep 30, 2010 at 04:00:41PM +0800, Mingkai Hu wrote:
[...]
> -static void mpc8xxx_spi_change_mode(struct spi_device *spi)
> +static void fsl_spi_change_mode(struct spi_device *spi)
> {
> struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
> struct spi_mpc8xxx_cs *cs = spi->controller_state;
> - __be32 __iomem *mode = &mspi->base->mode;
> + struct fsl_spi_reg *reg_base = (struct fsl_spi_reg *)mspi->reg_base;
No need for these type casts (the same is for the whole patch).
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-10-01 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 8:00 [PATCH v3 0/7] refactor spi_mpc8xxx.c and add eSPI controller support Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 1/7] spi/mpc8xxx: rename spi_mpc8xxx.c to spi_fsl_spi.c Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 3/7] eSPI: add eSPI controller support Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 4/7] powerpc/of: add eSPI controller dts bindings and DTS modification Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 5/7] mtd: m25p80: add support to parse the SPI flash's partitions Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 7/7] DTS: add fsl,spi-quirk-trans-len-limit property Mingkai Hu
2010-09-30 21:41 ` [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Grant Likely
2010-09-30 21:34 ` [PATCH v3 5/7] mtd: m25p80: add support to parse the SPI flash's partitions Grant Likely
2010-10-08 2:42 ` Hu Mingkai-B21284
2010-10-01 11:22 ` [PATCH v3 3/7] eSPI: add eSPI controller support Anton Vorontsov
2010-10-08 6:35 ` Hu Mingkai-B21284
2010-10-01 11:22 ` Anton Vorontsov [this message]
2010-10-08 6:37 ` [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Hu Mingkai-B21284
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001112212.GA17505@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=Mingkai.hu@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).