From: David Miller <davem@davemloft.net>
To: jwboyer@gmail.com
Cc: sfr@canb.auug.org.au, eric.dumazet@gmail.com, rsarmah@apm.com,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
therbert@google.com
Subject: Re: All Applied micro boards are failing with current mainline kernel
Date: Mon, 01 Nov 2010 08:51:26 -0700 (PDT) [thread overview]
Message-ID: <20101101.085126.71102684.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTin3nsb6FfNtXfqjZCuV66mwKVOsKgmZpTABFDUJ@mail.gmail.com>
From: Josh Boyer <jwboyer@gmail.com>
Date: Mon, 1 Nov 2010 11:39:47 -0400
> On Mon, Nov 1, 2010 at 11:36 AM, Stephen Rothwell <sfr@canb.auug.org.=
au> wrote:
>> Hi Josh,
>>
>> On Mon, 1 Nov 2010 11:05:53 -0400 Josh Boyer <jwboyer@gmail.com> wro=
te:
>>>
>>> A few hints would be appreciated.
>>
>> Remove the call to netif_stop_queue() from emac_probe(). =A0Apparent=
ly,
>> calling this before register_netdev() is now wrong (maybe always was=
).
> =
> Yeah, I just discovered that myself. I'm wondering
> =
> 1) why we do that in that function?
Because likely it was blindly copied from some other driver.
> 2) If it needs to be removed entirely, or moved to after the
> register_netdev call
Removed entirely.
> 3) If the call to netif_carrier_off also needs similar attention.
Not really.
> I can whip up a patch to remove those calls or move them after the
> register, but I don't want to do that without knowing which one is
> "right".
I've already taken care of this.
next prev parent reply other threads:[~2010-11-01 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Act3331keWjsN/sHTZGScnUum3AwDw==>
[not found] ` <6631e123845856ac20423c25e07844c8@mail.gmail.com>
2010-11-01 13:22 ` All Applied micro boards are failing with current mainline kernel Josh Boyer
2010-11-01 15:05 ` Josh Boyer
2010-11-01 15:36 ` Stephen Rothwell
2010-11-01 15:39 ` Josh Boyer
2010-11-01 15:51 ` David Miller [this message]
2010-11-01 16:14 ` Josh Boyer
2010-11-01 15:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101.085126.71102684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rsarmah@apm.com \
--cc=sfr@canb.auug.org.au \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).