From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: tmarri@apm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATHC v1] PPC4xx: Adding PCI(E) MSI support
Date: Wed, 3 Nov 2010 08:48:40 -0400 [thread overview]
Message-ID: <20101103124840.GA25950@zod.rchland.ibm.com> (raw)
In-Reply-To: <1288786293.989.65.camel@concordia>
On Wed, Nov 03, 2010 at 11:11:33PM +1100, Michael Ellerman wrote:
>> + struct device_node *msi_dev = NULL;
>> + const u32 *count;
>> +
>> + msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
>> + if (msi_dev)
>> + return -ENODEV;
>> +
You also leak a reference to the node here, as there is never a call to
of_node_put.
josh
next prev parent reply other threads:[~2010-11-03 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 22:55 [PATHC v1] PPC4xx: Adding PCI(E) MSI support tmarri
2010-11-03 12:11 ` Michael Ellerman
2010-11-03 12:48 ` Josh Boyer [this message]
2010-11-05 1:58 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103124840.GA25950@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).