From: David Gibson <david@gibson.dropbear.id.au>
To: Mitch Bradley <wmb@firmworks.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts
Date: Tue, 16 Nov 2010 09:30:09 +1100 [thread overview]
Message-ID: <20101115223009.GA4895@yookeroo> (raw)
In-Reply-To: <4CE1B18F.2030906@firmworks.com>
On Mon, Nov 15, 2010 at 12:17:51PM -1000, Mitch Bradley wrote:
> In general I think it's better to report parameter values directly,
> instead of inferring them from manufacturer and part numbers. That
> way you at least have a fighting chance of avoiding a kernel upgrade
> when a part changes.
I tend to agree. Although a fallback to deducing from the
manufacturer / part id if the pagesize property is missing would be
sensible.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2010-11-15 22:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:25 [PATCH 1/2] misc: at24: parse OF-data, too Wolfram Sang
2010-11-15 17:25 ` [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts Wolfram Sang
2010-11-15 17:32 ` Anton Vorontsov
2010-11-15 21:06 ` Mitch Bradley
2010-11-15 21:24 ` Anton Vorontsov
2010-11-15 21:58 ` Grant Likely
2010-11-15 22:17 ` Mitch Bradley
2010-11-15 22:30 ` David Gibson [this message]
2010-11-15 22:11 ` Wolfram Sang
2010-11-16 21:45 ` Wolfram Sang
2010-11-16 22:03 ` Anton Vorontsov
2010-11-15 21:41 ` [PATCH 1/2] misc: at24: parse OF-data, too Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115223009.GA4895@yookeroo \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wmb@firmworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).