From: Wolfram Sang <w.sang@pengutronix.de>
To: Stijn Devriendt <HIGHGuY@gmail.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH 1/3] misc: at24: parse OF-data, too
Date: Sat, 20 Nov 2010 13:42:26 +0100 [thread overview]
Message-ID: <20101120124226.GB11936@pengutronix.de> (raw)
In-Reply-To: <5F1D4949966C4C509360407B0F948EFE@HIGHGuY>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
Hi,
> As far as I could tell, using compatible = <24c64>; didn't load the right
> module (module name is at24) and using at24 caused a device id mismatch
> because at24 is not a known device ID. I could be wrong here and if so, I'd
> very much like a source code hint as to why...
Have you tried "<vendor>, 24c64"? All I can say is that it works for me. Plain
at24 worked for years with pcm030.dts and pcm032.dts, so I don't know which
issue you are facing. This patch is just about extending the support.
> My patch worked by changing drivers/of/of_i2c.c to allow a generic
> kind = " " statement that was filled in as i2c_board_info.type, to allow
> the module name and the device id to be different.
> This makes the at24 driver no longer rely on probing (which it claims
> is buggy anyway) and also benefits other drivers that support multiple
> devices, but where probing is difficult (e.g. lm90 driver).
>
> I'm in the process of getting employer approval to get these patches
> upstream.
I hope you will get it approved, it is a lot easier to talk about code :)
Best regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-11-20 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 12:00 [PATCH V2 0/3] at24: parse OF-data Wolfram Sang
2010-11-17 12:00 ` [PATCH 1/3] misc: at24: parse OF-data, too Wolfram Sang
2010-11-20 10:54 ` Stijn Devriendt
2010-11-20 12:42 ` Wolfram Sang [this message]
2010-11-20 14:07 ` Stijn Devriendt
2010-11-22 16:48 ` Stijn Devriendt
2010-12-24 9:15 ` Grant Likely
2010-11-17 12:00 ` [PATCH 2/3] misc: at24: add more sanity checks for parameters Wolfram Sang
2010-12-24 9:15 ` Grant Likely
2010-11-17 12:00 ` [PATCH 3/3] powerpc: pcm030/032: add pagesize to dts Wolfram Sang
2010-12-24 9:15 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101120124226.GB11936@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=HIGHGuY@gmail.com \
--cc=devicetree-discuss@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).