From: Stefan Roese <sr@denx.de>
To: Rupjyoti Sarmah <rsarmah@apm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board
Date: Wed, 24 Nov 2010 06:30:26 +0100 [thread overview]
Message-ID: <201011240630.26570.sr@denx.de> (raw)
In-Reply-To: <602c780cd2a81ee32f834a82814fe77f@mail.gmail.com>
On Wednesday 24 November 2010 05:55:03 Rupjyoti Sarmah wrote:
> >> +#define BCSR_USB_EN 0x11
> >
> >This define is wrong here. Its not common for all 44x platforms but
>
> Canyonlands specific.
>
> So, do you suggest to move this macro to the canyonlands.c ? Or introduce
> canyonlands.h ?
canyonlands.c is fine with me.
Cheers,
Stefan
next prev parent reply other threads:[~2010-11-24 5:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 12:56 [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board Rupjyoti Sarmah
2010-11-23 13:21 ` Stefan Roese
2010-11-23 21:10 ` Benjamin Herrenschmidt
2010-11-24 4:55 ` Rupjyoti Sarmah
2010-11-24 5:30 ` Stefan Roese [this message]
2010-11-24 7:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011240630.26570.sr@denx.de \
--to=sr@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rsarmah@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).