From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: tmarri@apm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/dts: fix syntax bugs in bluestone.dts
Date: Tue, 4 Jan 2011 08:59:31 -0500 [thread overview]
Message-ID: <20110104135930.GA2364@zod.rchland.ibm.com> (raw)
In-Reply-To: <20110103210715.10427.56175.stgit@localhost6.localdomain6>
On Mon, Jan 03, 2011 at 02:07:40PM -0700, Grant Likely wrote:
>Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>---
>
>I'm picking this one up immediately into my next-devicetree branch
Hm. So these are of course correct, and with that:
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
but I do wonder how you noticed them? DTC didn't throw an error when I
built this originally. Either way, more diligence on my part would be
appropriate, but knowing how you came across these might teach me
something.
Nit: C++ comments still make me get queasy. Maybe just remove the
properties that point to lables that don't exist?
josh
next prev parent reply other threads:[~2011-01-04 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 21:07 [PATCH] powerpc/dts: fix syntax bugs in bluestone.dts Grant Likely
2011-01-04 13:59 ` Josh Boyer [this message]
2011-01-04 14:30 ` Grant Likely
2011-01-04 14:31 ` Josh Boyer
2011-01-04 18:38 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104135930.GA2364@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).