From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e34.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 2F478B70E2 for ; Wed, 5 Jan 2011 01:00:59 +1100 (EST) Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p04Do0w5023317 for ; Tue, 4 Jan 2011 06:50:00 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p04E0gDP088056 for ; Tue, 4 Jan 2011 07:00:43 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p04E0foH006324 for ; Tue, 4 Jan 2011 07:00:41 -0700 Date: Tue, 4 Jan 2011 08:59:31 -0500 From: Josh Boyer To: Grant Likely Subject: Re: [PATCH] powerpc/dts: fix syntax bugs in bluestone.dts Message-ID: <20110104135930.GA2364@zod.rchland.ibm.com> References: <20110103210715.10427.56175.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110103210715.10427.56175.stgit@localhost6.localdomain6> Cc: tmarri@apm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 03, 2011 at 02:07:40PM -0700, Grant Likely wrote: >Signed-off-by: Grant Likely >--- > >I'm picking this one up immediately into my next-devicetree branch Hm. So these are of course correct, and with that: Acked-by: Josh Boyer but I do wonder how you noticed them? DTC didn't throw an error when I built this originally. Either way, more diligence on my part would be appropriate, but knowing how you came across these might teach me something. Nit: C++ comments still make me get queasy. Maybe just remove the properties that point to lables that don't exist? josh