From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pw0-f51.google.com (mail-pw0-f51.google.com [209.85.160.51]) by ozlabs.org (Postfix) with ESMTP id 44010B70A9 for ; Wed, 5 Jan 2011 05:39:02 +1100 (EST) Received: by pwj4 with SMTP id 4so2365774pwj.38 for ; Tue, 04 Jan 2011 10:39:00 -0800 (PST) Sender: Grant Likely Date: Tue, 4 Jan 2011 11:38:58 -0700 From: Grant Likely To: Josh Boyer Subject: Re: [PATCH] powerpc/dts: fix syntax bugs in bluestone.dts Message-ID: <20110104183858.GA2425@angua.secretlab.ca> References: <20110103210715.10427.56175.stgit@localhost6.localdomain6> <20110104135930.GA2364@zod.rchland.ibm.com> <20110104143030.GA11738@angua.secretlab.ca> <20110104143132.GC2364@zod.rchland.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110104143132.GC2364@zod.rchland.ibm.com> Cc: tmarri@apm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jan 04, 2011 at 09:31:32AM -0500, Josh Boyer wrote: > On Tue, Jan 04, 2011 at 07:30:30AM -0700, Grant Likely wrote: > >On Tue, Jan 04, 2011 at 08:59:31AM -0500, Josh Boyer wrote: > >> On Mon, Jan 03, 2011 at 02:07:40PM -0700, Grant Likely wrote: > >> >Signed-off-by: Grant Likely > >> >--- > >> > > >> >I'm picking this one up immediately into my next-devicetree branch > >> > >> Hm. So these are of course correct, and with that: > >> > >> Acked-by: Josh Boyer > >> > >> but I do wonder how you noticed them? DTC didn't throw an error when I > >> built this originally. Either way, more diligence on my part would be > >> appropriate, but knowing how you came across these might teach me > >> something. > > > >I updated the copy of dtc in the kernel and rebuilt all the .dts files. > > Are you going to push that DTC update into the kernel as well? Yes, that's what I mean by updating dtc. It is in my next-devicetree branch. g.