From: Grant Likely <grant.likely@secretlab.ca>
To: David Gibson <david@gibson.dropbear.id.au>,
"Blanchard, Hollis" <Hollis_Blanchard@mentor.com>,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Scott Wood <scottwood@freescale.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Saxena, Deepak" <deepak_saxena@mentor.com>
Subject: Re: [PATCH] of/device: Don't register disabled devices
Date: Fri, 7 Jan 2011 10:23:04 -0700 [thread overview]
Message-ID: <20110107172304.GC25446@angua.secretlab.ca> (raw)
In-Reply-To: <20110105233535.GB8846@yookeroo>
On Thu, Jan 06, 2011 at 10:35:35AM +1100, David Gibson wrote:
> On Wed, Jan 05, 2011 at 02:53:27PM -0800, Blanchard, Hollis wrote:
> > On 01/03/2011 03:01 PM, Grant Likely wrote:
> > > Device nodes with the property status="disabled" are not usable and so
> > > don't register them when parsing the device tree for devices.
> > >
> > This is great and all, but a fair amount of driver code explicitly
> > searches the tree, rather than registering a probe function. That's why
> > our earlier patches in this area were more comprehensive.
As your patch set shows, the total set isn't unmanageable, and the
preference for new code is to use the device model infrastructure if
at all possible.
> >
> > What are your thoughts on handling those cases?
>
> One by one. Trying to handle the explicit searches automagically is
> just asking for trouble.
Just as David says, the special cases are... well... special.
Anything making decisions about registering devices needs to follow
the status!="okay" rules.
g.
prev parent reply other threads:[~2011-01-07 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 23:01 [PATCH] of/device: Don't register disabled devices Grant Likely
2011-01-05 22:53 ` Blanchard, Hollis
2011-01-05 23:35 ` David Gibson
2011-01-07 17:23 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107172304.GC25446@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=Hollis_Blanchard@mentor.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=deepak_saxena@mentor.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).